This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Refocus after application of Code Action #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 37.31% 37.29% -0.03%
==========================================
Files 162 162
Lines 5159 5162 +3
==========================================
Hits 1925 1925
- Misses 3234 3237 +3
Continue to review full report at Codecov.
|
|
Ah! yeah I think the suggestion in the issue was a little off; I don't think the two code paths are mutually exclusive but I believe that the |
Remove extra code
facebook-github-bot
pushed a commit
to facebookarchive/nuclide
that referenced
this pull request
Jan 23, 2018
Summary: Imports facebookarchive/atom-ide-ui#152. It's a small PR to give the editor focus after clicking a code action (to avoid a situation where nothing has focus). Reviewed By: matthewwithanm Differential Revision: D6788648 fbshipit-source-id: 406705d6d2b513652489f9d353779f48d81edac9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the application of a code action return focus to active text editor to prevent the appearance of 'cursor locking' after applying a code action. I made this change in two places, for my test actions I only observed the code in
DiagnosticsCodeActions.jsactually being ran. My assumption being that the two calls to the underlying code action'sapplymethod are mutually exclusive, feel free to correct me if that's a bad assumption. Also note that inDiagnosticsCodeActions.jsthe 'active element' is refocused even after code action failure, this seems like the desired behavior but let me know if it's not for any reason.Fixes #147