force launchd to unload plist #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: in facebook#358 we ended up in a state where the contents of the plist were correct but launchd still thought that it should be monitoring the older 4.6 binary. I don't know how we ended up in such a state, as we unload before we write out the new plist. My working theory is that the unload failed for some unknown reason but we carried on anyway. Also, this nugget from the man page: > NOTE: Due to bugs in the previous implementation and long-standing > client expectations around those bugs, the load and unload subcommands > will only return a non-zero exit code due to improper usage. > Otherwise, zero is always returned. This is a speculative diff to add the `-F` force flag in. I have no way to prove whether this will solve this, only that it doesn't break spawning watchman for me today. Test Plan: with watchman not running and my plist referencing the internal FB build of watchman, build and run watchman from the checkout on my mac as `./watchman version`. Inspect the plist and observe that the executable path has changed from the installed location of the binary to the path to my checkout and that we got a valid watchman version response.
|
By analyzing the blame information on this pull request, we identified @Sid0 and @dhruvsinghal to be potential reviewers. |
ghost
closed this
in
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: in #358 we ended up
in a state where the contents of the plist were correct but launchd
still thought that it should be monitoring the older 4.6 binary.
I don't know how we ended up in such a state, as we unload before we
write out the new plist.
My working theory is that the unload failed for some unknown reason but
we carried on anyway.
Also, this nugget from the man page:
This is a speculative diff to add the
-Fforce flag in. I have no wayto prove whether this will solve this, only that it doesn't break
spawning watchman for me today.
Test Plan: with watchman not running and my plist referencing the
internal FB build of watchman, build and run watchman from the checkout
on my mac as
./watchman version. Inspect the plist and observe thatthe executable path has changed from the installed location of the
binary to the path to my checkout and that we got a valid watchman
version response.