Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Compile time error in ConnectionManager::makeUnique #12

Closed
wants to merge 1 commit into from
Closed

Fix: Compile time error in ConnectionManager::makeUnique #12

wants to merge 1 commit into from

Commits on Oct 15, 2015

  1. Fix: Compile time error in ConnectionManager::makeUnique 

    ConnectionManager::makeUnique was calling folly::make_unique with an extra
template argument (destructor). It looks like the folly code use to accept this
in the past. Now folly updated it to be more C++14 standard compliant and it no
longer accepts second template argument.

http://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique
    @mtanski
    mtanski committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    a0782b6 View commit details
    Browse the repository at this point in the history