Add logging for normalization

Reviewed By: gordyf Differential Revision: D62901540 fbshipit-source-id: 96e1a2fe340098ae9800606a9af41ce1b614aef2
facebook · Sep 18, 2024 · ba0b469 · ba0b469
1 parent da733d3
commit ba0b469
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 3 deletions.
diff --git a/packages/react-relay/relay-hooks/__tests__/useLazyLoadQueryNode-test.js b/packages/react-relay/relay-hooks/__tests__/useLazyLoadQueryNode-test.js
@@ -942,7 +942,7 @@ describe('logging', () => {
       {
         name: 'queryresource.fetch',
         resourceID: 200000,
-        profilerContext: expect.objectContaining({}),
+        profilerContext: {},
       },
       {
         name: 'suspense.query',
@@ -964,6 +964,12 @@ describe('logging', () => {
         name: 'execute.next.start',
         executeId: 100001,
       },
+      {
+        name: 'execute.normalize.start',
+      },
+      {
+        name: 'execute.normalize.end',
+      },
       {
         name: 'execute.next.end',
         executeId: 100001,
@@ -979,7 +985,7 @@ describe('logging', () => {
       {
         name: 'queryresource.retain',
         resourceID: 200000,
-        profilerContext: expect.objectContaining({}),
+        profilerContext: {},
       },
     ]);
   });
@@ -1148,6 +1154,12 @@ describe('logging', () => {
         name: 'execute.next.start',
         executeId: 100002,
       },
+      {
+        name: 'execute.normalize.start',
+      },
+      {
+        name: 'execute.normalize.end',
+      },
       {
         name: 'execute.next.end',
         executeId: 100002,

diff --git a/packages/relay-runtime/store/OperationExecutor.js b/packages/relay-runtime/store/OperationExecutor.js
@@ -773,6 +773,10 @@ class Executor<TMutation: MutationParameters> {
   _processResponses(
     responses: $ReadOnlyArray<GraphQLResponseWithData>,
   ): $ReadOnlyArray<RelayResponsePayload> {
+    this._log({
+      name: 'execute.normalize.start',
+      operation: this._operation,
+    });
     if (this._optimisticUpdates !== null) {
       this._optimisticUpdates.forEach(update => {
         this._getPublishQueueAndSaveActor().revertUpdate(update);
@@ -801,7 +805,10 @@ class Executor<TMutation: MutationParameters> {
         relayPayload,
         this._updater,
       );
-
+      this._log({
+        name: 'execute.normalize.end',
+        operation: this._operation,
+      });
       return relayPayload;
     });
   }

diff --git a/packages/relay-runtime/store/RelayStoreTypes.js b/packages/relay-runtime/store/RelayStoreTypes.js
@@ -695,6 +695,16 @@ export type ExecuteCompleteLogEvent = {
   +executeId: number,
 };
 
+export type ExecuteNormalizeStart = {
+  +name: 'execute.normalize.start',
+  +operation: OperationDescriptor,
+};
+
+export type ExecuteNormalizeEnd = {
+  +name: 'execute.normalize.end',
+  +operation: OperationDescriptor,
+};
+
 export type StoreDataCheckerStartEvent = {
   +name: 'store.datachecker.start',
   +selector: NormalizationSelector,
@@ -801,6 +811,8 @@ export type LogEvent =
   | ExecuteAsyncModuleLogEvent
   | ExecuteErrorLogEvent
   | ExecuteCompleteLogEvent
+  | ExecuteNormalizeStart
+  | ExecuteNormalizeEnd
   | StoreDataCheckerStartEvent
   | StoreDataCheckerEndEvent
   | StorePublishLogEvent