Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update broken icon link (circleCi status) #26688

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

itaim18
Copy link
Contributor

@itaim18 itaim18 commented Apr 20, 2023

looks better now πŸš€β€Š

Summary

How did you test this change?

visually on README.md on github
image

looks better now πŸš€β€Š
@facebook-github-bot
Copy link

Hi @itaim18!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@itaim18
Copy link
Contributor Author

itaim18 commented Apr 20, 2023

This closes #26687

@react-sizebot
Copy link

Comparing: cc93a85...e918acc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 163.95 kB 163.95 kB = 51.67 kB 51.67 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 167.70 kB 167.70 kB = 52.81 kB 52.81 kB
facebook-www/ReactDOM-prod.classic.js = 566.07 kB 566.07 kB = 100.25 kB 100.25 kB
facebook-www/ReactDOM-prod.modern.js = 549.80 kB 549.80 kB = 97.57 kB 97.57 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e918acc

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@sophiebits sophiebits merged commit c836952 into facebook:main Apr 21, 2023
@sophiebits
Copy link
Contributor

thanks!

kassens pushed a commit that referenced this pull request Apr 21, 2023
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
looks better now πŸš€β€Š

DiffTrain build for commit c836952.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants