-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored DevTools test shell for e2e #22968
Conversation
await page.goto('http://localhost:8080/', {waitUntil: 'domcontentloaded'}); | ||
await page.waitForSelector('iframe#target'); | ||
frameElementHandle = await page.$('#target'); | ||
await page.goto('http://localhost:8080/e2e.html', {waitUntil: 'domcontentloaded'}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Longer term, relying on our test shell for e2e tests seems too fragile. Changing one shouldn't break the other. So I added a specific e2e target.
"start": "yarn start:app", | ||
"start:app": "cross-env NODE_ENV=development cross-env TARGET=local webpack-dev-server --open-page app.html", | ||
"start:multi": "cross-env NODE_ENV=development cross-env TARGET=local webpack-dev-server --open-page multi.html" | ||
"start": "cross-env NODE_ENV=development cross-env TARGET=local webpack-dev-server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the app.html
file to index.html
and added a small nav bar up top so we can get rid of these separate targets.
root.render(createElement(App)); | ||
} | ||
|
||
mountApp(ToDoList); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to add e2e-specific things rather than reuse our ToDo app but this is okay for now.
6f4e76c
to
cf679b5
Compare
Looks like NPM services are down at the moment so the Circle CI failures are not surprising (but also not caused by this PR). |
cf679b5
to
6e259a3
Compare
This partially fixes a regression in the e2e target and makes things easier (hopefully) going forward when adding new e2e tests.
6e259a3
to
195490d
Compare
Fixes a regression in the e2e target and makes things easier (hopefully) going forward when adding new e2e tests.
Fixes a regression in the e2e target and makes things easier (hopefully) going forward when adding new e2e tests.
Fixes a regression in the e2e target and makes things easier (hopefully) going forward when adding new e2e tests.
I think we should follow up with a few things after this:
"span[class^=Value]"
(maybe the Test Selector API could help with this?)