Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offscreen: Use JS stack to track hidden/unhidden subtree state #21195

Closed
wants to merge 1 commit into from
Closed

Offscreen: Use JS stack to track hidden/unhidden subtree state #21195

wants to merge 1 commit into from

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 7, 2021 •
edited
Loading

Follow-ups to #21079

Re-landing #21192 which got merged accidentally b'c of a false positive from CI.

Failing (variant) tests to fix

  • packages/react/src/tests/ReactProfiler-test.internal.js
  • packages/react-reconciler/src/tests/ReactSuspensePlaceholder-test.internal.js
  • packages/react-reconciler/src/tests/ReactSuspenseList-test.js

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Apr 7, 2021
@bvaughn
Copy link
Contributor Author

bvaughn commented Apr 8, 2021

Closing in favor of #21211

@bvaughn bvaughn closed this Apr 8, 2021
@bvaughn bvaughn deleted the revert-21194-revert-21192-offscreen-effects-semantics-use-js-stack branch April 8, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvaughn @facebook-github-bot