Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traverse commit phase effects iteratively #20094

Merged
merged 2 commits into from
Oct 27, 2020

Commits on Oct 23, 2020

  1. Move traversal logic to ReactFiberCommitWork

    The current traversal logic is spread between ReactFiberWorkLoop and
    ReactFiberCommitWork, and it's a bit awkward, especially when
    refactoring. Idk the ideal module structure, so for now I'd rather keep
    it all in one file.
    acdlite committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3f28b23 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Traverse commit phase effects iteratively

    We suspect that using the JS stack to traverse through the tree in the
    commit phase is slower than traversing iteratively.
    
    I've kept the recursive implementation behind a flag, both so we have
    the option to run an experiment comparing the two, and so we can revert
    it easily later if needed.
    acdlite committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    368930d View commit details
    Browse the repository at this point in the history