Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools: Remove ReactJS.org version check "cheat" #19939

Merged
merged 2 commits into from
Oct 1, 2020
Merged

DevTools: Remove ReactJS.org version check "cheat" #19939

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6d64f1
update url in the check to reactjs.org for the development version ch…
sktguha Sep 30, 2020
d61f709
Remove dead code as facebook.github.io/react always redirects to reac…
sktguha Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions packages/react-devtools-extensions/src/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,18 +98,7 @@ chrome.runtime.onMessage.addListener((request, sender) => {
// We use browserAction instead of pageAction because this lets us
// display a custom default popup when React is *not* detected.
// It is specified in the manifest.
let reactBuildType = request.reactBuildType;
if (sender.url.indexOf('facebook.github.io/react') !== -1) {
// Cheat: We use the development version on the website because
// it is better for interactive examples. However we're going
// to get misguided bug reports if the extension highlights it
// as using the dev version. We're just going to special case
// our own documentation and cheat. It is acceptable to use dev
// version of React in React docs, but not in any other case.
reactBuildType = 'production';
}

setIconAndPopup(reactBuildType, sender.tab.id);
setIconAndPopup(request.reactBuildType, sender.tab.id);
}
}
});