Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove concurrent apis from stable #17088

Merged
merged 5 commits into from
Oct 15, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 14, 2019

Those who want to try concurrent mode should use the experimental builds instead.

I also turned on the Suspense server renderer and selective hydration in the experimental build.

@sizebot
Copy link

sizebot commented Oct 14, 2019

ReactDOM: size: -0.0%, gzip: -0.1%

Details of bundled changes.

Comparing: a8c6a1b...38e5bb7

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js -0.5% -0.4% 119.46 KB 118.89 KB 37.7 KB 37.56 KB NODE_PROFILING
react-dom-server.browser.development.js -0.0% -0.0% 140.06 KB 140 KB 36.8 KB 36.79 KB UMD_DEV
ReactDOM-dev.js -0.0% -0.0% 968.76 KB 968.52 KB 215.37 KB 215.31 KB FB_WWW_DEV
react-dom-server.browser.production.min.js -0.0% -0.1% 19.84 KB 19.83 KB 7.37 KB 7.36 KB UMD_PROD
react-dom-test-utils.development.js -0.1% -0.1% 56.31 KB 56.26 KB 15.59 KB 15.57 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.78 KB 3.78 KB 1.53 KB 1.53 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.2 KB 1.2 KB 701 B 702 B UMD_PROD
react-dom-test-utils.development.js -0.1% -0.1% 54.58 KB 54.53 KB 15.25 KB 15.24 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.04 KB 1.04 KB 632 B 633 B NODE_PROD
react-dom.development.js -0.0% -0.0% 946.8 KB 946.49 KB 214.52 KB 214.45 KB UMD_DEV
react-dom.production.min.js -0.5% -0.4% 115.7 KB 115.13 KB 37.25 KB 37.1 KB UMD_PROD
react-dom.profiling.min.js -0.5% -0.3% 119.22 KB 118.66 KB 38.33 KB 38.24 KB UMD_PROFILING
react-dom.development.js -0.0% -0.0% 940.87 KB 940.56 KB 212.95 KB 212.87 KB NODE_DEV
react-dom-server.node.development.js -0.0% -0.0% 137.1 KB 137.04 KB 36.02 KB 36.01 KB NODE_DEV
react-dom.production.min.js -0.5% -0.4% 115.81 KB 115.24 KB 36.69 KB 36.54 KB NODE_PROD
react-dom-server.node.production.min.js -0.0% -0.1% 20.17 KB 20.17 KB 7.5 KB 7.5 KB NODE_PROD
ReactDOM-prod.js -0.5% -0.4% 398.14 KB 396.34 KB 72.47 KB 72.17 KB FB_WWW_PROD
ReactDOM-profiling.js -0.5% -0.4% 398.87 KB 397.07 KB 72.99 KB 72.68 KB FB_WWW_PROFILING
react-dom-server.browser.development.js -0.0% -0.0% 135.99 KB 135.93 KB 35.8 KB 35.78 KB NODE_DEV
react-dom-server.browser.production.min.js -0.0% -0.1% 19.76 KB 19.76 KB 7.35 KB 7.35 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.13 KB 60.13 KB 15.79 KB 15.79 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.72 KB 10.72 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOMServer-dev.js -0.0% -0.0% 139.29 KB 139.28 KB 35.33 KB 35.32 KB FB_WWW_DEV
ReactDOMServer-prod.js -0.0% -0.0% 48.5 KB 48.49 KB 11.08 KB 11.07 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.8 KB 59.8 KB 15.66 KB 15.66 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.46 KB 10.46 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.2% 1.1 KB 1.1 KB 666 B 667 B NODE_PROD

Generated by 🚫 dangerJS against 38e5bb7

@@ -643,7 +624,7 @@ type RootOptions = {
},
};

function createRoot(
export function createRoot(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't do exports here, right? Why would you?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so I can add a prefixed version to the Facebook build:

ReactDOM.unstable_createRoot = createRoot;
ReactDOM.unstable_createSyncRoot = createSyncRoot;

I forgot this module is the public interface... I think it happens to work because only the .default export is reexported in the Common JS bundle, but maybe a better approach is to move the createRoot and other implementation stuff into a separate module.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok after talking offline, I've removed this. www will use the experimental builds.

@acdlite acdlite force-pushed the remove-concurrent-apis-from-stable branch 2 times, most recently from 653ffa7 to 8fbca06 Compare October 15, 2019 00:08
For local development, you usually want experiments enabled. Unless
the release channel is set with an environment variable, tests will
run with __EXPERIMENTAL__ set to `true`.
Those who want to try concurrent mode should use the experimental
builds instead.

I've left the `unstable_` prefixed APIs in the Facebook build so we
can continue experimenting with them internally without blessing them
for widespread use.
@acdlite acdlite force-pushed the remove-concurrent-apis-from-stable branch 4 times, most recently from ccf2758 to dca8802 Compare October 15, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants