Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Profiler API as stable #15172

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Mar 20, 2019

The Profiler RFC (reactjs/rfcs#51) is 10 months old and API hasn't changed in months. It seems like that we'll want to add a new API for Suspense metrics, but as a new prop that should not impact the existing onRender prop.

Maybe it's time to mark this API as stable? Opening for discussion purposes.

(If this lands, I will update and close out the RFC.)

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👣ship itttt

@bvaughn
Copy link
Contributor Author

bvaughn commented Mar 21, 2019

❤️

@bvaughn bvaughn merged commit 56035da into facebook:master Mar 21, 2019
@bvaughn bvaughn deleted the stable-Profiler branch March 21, 2019 16:18
@markerikson
Copy link
Contributor

Per my comment on Twitter the other day, it would be nice to have metrics for commit times too (especially if sync setState updates are causing those to extend).

@kevinSuttle
Copy link
Contributor

Awesome! Did this land in 16.8.5?

@bvaughn
Copy link
Contributor Author

bvaughn commented Mar 25, 2019

No, 16.9 😄

@kevinSuttle
Copy link
Contributor

Oh, nice. Good to know. Thanks!

@gaearon gaearon mentioned this pull request Jul 30, 2019
This was referenced Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants