Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same example code for async effect warning #15118

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 15, 2019

I know y'all are tired of me tweaking this...

So I tried CRA 3.0 alpha (facebook/create-react-app#6475) and realized it's confusing that both warnings show up with different snippets.

I also think the fully "correct" version is a bit too much for somebody writing this for the first time — and most class examples aren't correct either. So I opted instead to use the simpler first version, and the FAQ link shows you a better one.

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good, I trust your judgement for doing so. I suppose we'll revisit this again in the future anyway.

@gaearon gaearon merged commit f0621fe into facebook:master Mar 15, 2019
@gaearon gaearon deleted the consistent-warn branch March 15, 2019 19:27
gaearon added a commit to gaearon/react that referenced this pull request Mar 22, 2019
@gaearon gaearon mentioned this pull request Mar 22, 2019
This was referenced Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants