Consolidate all symbols in a single file #11629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the code duplication as we have quite a few now.
|
Seems fine but there was a reason to colocate them to begin with. The idea is that others shouldn't be asking for a canonical module to import these from, creating dependency quirks. Instead it should be duplicated. So if we colocate then it is easier for others to copy that pattern rather than try to import some module. E.g. by reaching into internals or trying to copy it from the React project. |
sebmarkbage
approved these changes
Nov 22, 2017
clemmy
approved these changes
Nov 22, 2017
|
They can't reach into React anymore anyway (thanks to flat bundles) so that's not a concern now. Thanks for explaining! |
raphamorim
pushed a commit
to raphamorim/react
that referenced
this pull request
Nov 27, 2017
* Consolidate all symbols in a single file This reduces the code duplication as we have quite a few now. * Record sizes
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Consolidate all symbols in a single file This reduces the code duplication as we have quite a few now. * Record sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the code duplication as we have quite a few of them now. It's also nice to be able to see them all together. Note this is
shared/so they're still duplicated between React and renderer packages.The actual file savings are negligible (a few dozen bytes after gzip for combined bundles). This is mostly to make it better from code organization perspective.
I tried putting them as a hidden export on the React object but this actually increased the size a bit because our secret export name is longer than the code this saves. 😛 Although maybe it would be nice to do in the future to fix cases like #8379 (comment). For now I decided not to do it.