-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing #5932 TouchableOpacity respect style opacity #8909
Fixing #5932 TouchableOpacity respect style opacity #8909
Conversation
By analyzing the blame information on this pull request, we identified @janicduplessis and @jesseruder to be potential reviewers. |
d0bb72f
to
90761ee
Compare
I have update pull request because there is also a bug when |
Anything I can do to get this merged faster? |
I would love to see this merged soon. |
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @janicduplessis as a potential reviewer. Could you take a look please or cc someone with more context? |
I've just added this to Product Pains on RN support page. Same title as #5932 |
0effe5e
to
90761ee
Compare
@gorangajic updated the pull request - view changes |
@@ -98,6 +106,7 @@ var TouchableOpacity = React.createClass({ | |||
touchableHandleActivePressIn: function(e: Event) { | |||
this.clearTimeout(this._hideTimeout); | |||
this._hideTimeout = null; | |||
this._pressIn = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this variable exist on TouchableOpacity or are you introducing a new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
introducing a new one
Is this still being tracked? Would really like this in the next update if possible. |
Just ran into this bug - definitely would be nice to get this one in, considering the footprint of this PR is quite small. |
@mkonicek are you satisfied with the latest changes from the author? |
I think this sort of bug fix is a good time to add a test, because it seems quite easy for someone else to inadvertently break this bugfix later. |
can anyone review this? @janicduplessis and @jesseruder? |
@janicduplessis @mkonicek @jesseruder pinging you guys again for the PR, please merge or give more feedback so we can know what needs to further be done. |
It looks like #12628 fixes the initial opacity but doesn't address the edge case mentioned above. Should this PR be closed/updated to address that edge case? |
It looks like the "edge case" mentioned above is important because if the opacity value changes, it should be updated. |
Agree. I have run into this as well (and it took some sleuthing to find this thread!). This PR is superior to #12628, IMO. |
Initial
opacity
onTouchableOpacity
Component is broken like it's pointed in issue #5932