[RN][iOS] autolinked package scripts use absolute path #46186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: A previous attempt at fixing this issue used a relative path (facebook#45208), this doesn't work if the user runs bundle install outside of the ios/ folder, using the --project-directory=ios argument. Changelog: [iOS][Fix] support bundle install from outside the ios folder using --project-directory Test Plan: Ran the command in a project with @react-native-firebase/app using the --project-directory, confirmed that it's fixed when using the absolute path. closes: reactwg/react-native-releases#341
facebook-github-bot
added
CLA Signed
|
1 similar comment
|
|
@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @blakef in b22970e When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 11, 2024
Summary: A previous attempt at fixing this issue used a relative path (#45208), this doesn't work if the user runs bundle install outside of the `ios/` folder, using the `--project-directory=ios` argument. ## Changelog: [iOS][Fixed] support bundle install from outside the ios folder using --project-directory Pull Request resolved: #46186 Test Plan: Ran the command in a project with `react-native-firebase/app` using the `--project-directory`, confirmed that it's fixed when using the absolute path. closes: reactwg/react-native-releases#341 Reviewed By: cipolleschi Differential Revision: D61719821 Pulled By: blakef fbshipit-source-id: d83429dd29c9e8cc066ab9843ad95fdfc0af8dea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A previous attempt at fixing this issue used a relative path (#45208),
this doesn't work if the user runs bundle install outside of the ios/
folder, using the --project-directory=ios argument.
Changelog:
[iOS][Fixed] - support bundle install from outside the ios folder using --project-directory
Test Plan:
Ran the command in a project with @react-native-firebase/app using the
--project-directory, confirmed that it's fixed when using the absolute
path.
closes: reactwg/react-native-releases#341