feat: Add role prop to Text component #34976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
gabrieldonadel
commented
Oct 14, 2022
| @@ -286,3 +291,69 @@ export interface AccessibilityPropsIOS { | |||
| */ | |||
| accessibilityIgnoresInvertColors?: boolean | undefined; | |||
| } | |||
|
|
|||
| export type Role = | |||
There was a problem hiding this comment.
These were missing on TS
react-native-bot
added
the
Type: Enhancement
gabrieldonadel
force-pushed
the
feat/add-role-to-text
branch
from
556d37c
to
44a7a9b
Compare
Base commit: 5d8a712 |
gabrieldonadel
force-pushed
the
feat/add-role-to-text
branch
from
44a7a9b
to
4799069
Compare
Base commit: 5d8a712 |
jacdebug
reviewed
Oct 14, 2022
| 'use strict'; | ||
|
|
||
| // Map role values to AccessibilityRole values | ||
| export const roleToAccessibilityRoleMapping = { |
There was a problem hiding this comment.
This object roleToAccessibilityRoleMapping needs to in JS VM heap all time after loading this JS. Consider making this is getter function so this object can be deallocated after the call, or better use a switch statement like this.
cc @javache
There was a problem hiding this comment.
Sure, I've just refactor it to be a switch statement
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 14, 2022
Summary: I've been noticing this for a while now, every time that someone changes a file inside rn-tester Danger comments a bunch of warnings regarding inline styles, e.g. #34567 (comment), even though that is disabled inside .eslintrc https://github.com/facebook/react-native/blob/8edf4e9e3adcc85743e3c86a25ab3748b276a3da/packages/rn-tester/.eslintrc#L3 After some investigation, I realized that the problem was that the Eslint Node.js API used by [seadub/danger-plugin-eslint](https://www.npmjs.com/package/seadub/danger-plugin-eslint) was not able to locate any `.eslintrc` files due to the location of the directory where danger is invoked. By using `process.chdir` we can ensure that eslint will run from the root folder and that it will be able to find all .eslintrc files ## Changelog [Internal] [Fixed] - fix eslint config when running Danger Pull Request resolved: #34980 Test Plan: run `yarn danger pr #34976 After  Before  Reviewed By: cortinico Differential Revision: D40384300 Pulled By: yungsters fbshipit-source-id: e68eeafc42567dc9d7297dde3709a989cc70f4e2
gabrieldonadel
force-pushed
the
feat/add-role-to-text
branch
from
4799069
to
15da31c
Compare
gabrieldonadel
force-pushed
the
feat/add-role-to-text
branch
from
15da31c
to
02082e4
Compare
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
Summary: I've been noticing this for a while now, every time that someone changes a file inside rn-tester Danger comments a bunch of warnings regarding inline styles, e.g. facebook#34567 (comment), even though that is disabled inside .eslintrc https://github.com/facebook/react-native/blob/8edf4e9e3adcc85743e3c86a25ab3748b276a3da/packages/rn-tester/.eslintrc#L3 After some investigation, I realized that the problem was that the Eslint Node.js API used by [seadub/danger-plugin-eslint](https://www.npmjs.com/package/seadub/danger-plugin-eslint) was not able to locate any `.eslintrc` files due to the location of the directory where danger is invoked. By using `process.chdir` we can ensure that eslint will run from the root folder and that it will be able to find all .eslintrc files ## Changelog [Internal] [Fixed] - fix eslint config when running Danger Pull Request resolved: facebook#34980 Test Plan: run `yarn danger pr facebook#34976 After  Before  Reviewed By: cortinico Differential Revision: D40384300 Pulled By: yungsters fbshipit-source-id: e68eeafc42567dc9d7297dde3709a989cc70f4e2
70 tasks
|
@jacdebug would you mind rereviwing this PR? |
jacdebug
approved these changes
Oct 20, 2022
necolas
approved these changes
Oct 20, 2022
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @gabrieldonadel in 20718e6. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: I've been noticing this for a while now, every time that someone changes a file inside rn-tester Danger comments a bunch of warnings regarding inline styles, e.g. facebook#34567 (comment), even though that is disabled inside .eslintrc https://github.com/facebook/react-native/blob/8edf4e9e3adcc85743e3c86a25ab3748b276a3da/packages/rn-tester/.eslintrc#L3 After some investigation, I realized that the problem was that the Eslint Node.js API used by [seadub/danger-plugin-eslint](https://www.npmjs.com/package/seadub/danger-plugin-eslint) was not able to locate any `.eslintrc` files due to the location of the directory where danger is invoked. By using `process.chdir` we can ensure that eslint will run from the root folder and that it will be able to find all .eslintrc files ## Changelog [Internal] [Fixed] - fix eslint config when running Danger Pull Request resolved: facebook#34980 Test Plan: run `yarn danger pr facebook#34976 After  Before  Reviewed By: cortinico Differential Revision: D40384300 Pulled By: yungsters fbshipit-source-id: e68eeafc42567dc9d7297dde3709a989cc70f4e2
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: As pointed out by necolas on facebook#34424 (comment) we forgot we add the `role` prop mapping to the `Text` component. This PR adds a new `role` prop to `Text`, mapping the web `role` values to the already existing `accessibilityRole` prop and moves the `roleToAccessibilityRoleMapping` to a common file that can be imported by both the `Text` and `View` components as requested on facebook#34424. This PR also updates the RNTester AcessebilityExample to include a test using this new prop. ## Changelog [General] [Added] - Add role prop to Text component Pull Request resolved: facebook#34976 Test Plan: 1. Open the RNTester app and navigate to the Accessibility Example page 2. Test the `role` prop through the `Text with role = heading` section Reviewed By: yungsters Differential Revision: D40596039 Pulled By: jacdebug fbshipit-source-id: f72f02e8bd32169423ea517ad18b598b52257b17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As pointed out by @necolas on #34424 (comment) we forgot we add the
roleprop mapping to theTextcomponent. This PR adds a newroleprop toText, mapping the webrolevalues to the already existingaccessibilityRoleprop and moves theroleToAccessibilityRoleMappingto a common file that can be imported by both theTextandViewcomponents as requested on #34424. This PR also updates the RNTester AcessebilityExample to include a test using this new prop.Changelog
[General] [Added] - Add role prop to Text component
Test Plan
roleprop through theText with role = headingsection