Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added aria-live as a alias for accessibility-live-region #34555

Conversation

mayank-96
Copy link
Contributor

Summary

This adds aria-live alias for accessibilityLiveRegion, it unifies aria-live and accessibilityLiveRegion and also maps aria-live='off' to accessibilityLiveRegion='none' as requested on #34424

Changelog

[General][Added] - Added aria-live alias for accessibilityLiveRegion.

Test Plan

<View aria-live="polite">
  <Text>Clicked {this.state.count} times</Text>
</View>

<View aria-live="off">
  <Text>Clicked {this.state.count} times</Text>
</View>

@facebook-github-bot
Copy link
Contributor

Hi @mayank-96!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 1, 2022
@analysis-bot
Copy link

analysis-bot commented Sep 1, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,639,593 +106
android hermes armeabi-v7a 7,051,827 +112
android hermes x86 7,941,171 +109
android hermes x86_64 7,913,165 +113
android jsc arm64-v8a 9,513,883 +222
android jsc armeabi-v7a 8,289,490 +213
android jsc x86 9,453,215 +215
android jsc x86_64 10,044,278 +212

Base commit: 98d84e5
Branch: main

@analysis-bot
Copy link

analysis-bot commented Sep 1, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 62f83a9
Branch: main

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 1, 2022
@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Libraries/Components/Pressable/Pressable.js Outdated Show resolved Hide resolved
Libraries/Components/Touchable/TouchableWithoutFeedback.js Outdated Show resolved Hide resolved
Libraries/Components/View/ViewPropTypes.js Outdated Show resolved Hide resolved
@mayank-96
Copy link
Contributor Author

Hello @necolas, Let me know if anything else needs to be done here.

@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mayank-96 in 7ea54a4.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 8, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…ook#34555)

Summary:
This adds `aria-live` alias for `accessibilityLiveRegion`, it unifies aria-live and accessibilityLiveRegion and also maps `aria-live='off'` to `accessibilityLiveRegion='none'` as requested on facebook#34424

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General][Added] - Added aria-live alias for accessibilityLiveRegion.

Pull Request resolved: facebook#34555

Test Plan:
```js
<View aria-live="polite">
  <Text>Clicked {this.state.count} times</Text>
</View>

<View aria-live="off">
  <Text>Clicked {this.state.count} times</Text>
</View>
```

Reviewed By: cipolleschi

Differential Revision: D39206291

Pulled By: jacdebug

fbshipit-source-id: fd2019e7047ff7ff6133fed39f1a70b5a9396f89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs TypeScript Update Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants