feat: Add tintColor prop to Image component #34534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
Base commit: 10ea6fb |
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 10ea6fb |
necolas
reviewed
Aug 30, 2022
Libraries/Image/ImageProps.js
Outdated
| @@ -14,6 +14,7 @@ import type {SyntheticEvent, LayoutEvent} from '../Types/CoreEventTypes'; | |||
| import type {EdgeInsetsProp} from '../StyleSheet/EdgeInsetsPropType'; | |||
| import type {ImageSource} from './ImageSource'; | |||
| import type {ViewStyleProp, ImageStyleProp} from '../StyleSheet/StyleSheet'; | |||
| import type {____ColorValue_Internal} from '../StyleSheet/StyleSheetTypes'; | |||
There was a problem hiding this comment.
I think we'll want to import the type like this:
There was a problem hiding this comment.
Good point, I've just updated it.
necolas
approved these changes
Aug 31, 2022
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @gabrieldonadel in 7a6f0e4. When will my fix make it into a release? | Upcoming Releases |
70 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the
tintColorprop to the Image component to replace the non-standardstyle.tintColoras requested on #34424, so that React Native for Web does not have to deopt styles for Image rendering. I didn't have to change anything on Android astintColorwas already being passed down to the native component as a prop. This PR also updates RNTester ImageExample in order to facilitate the manual QA.Changelog
[General] [Added] - Add tintColor prop to Image component
Test Plan
tintColorprop through theTint ColorsectionScreen.Recording.2022-08-30.at.10.07.40.mov