Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump NDK toolchain to 4.9 #19945

Closed
wants to merge 5 commits into from

Conversation

dulmandakh
Copy link
Contributor

This PR will bump NDK_TOOLCHAIN_VERSION to 4.9 or use GCC 4.9 to build C++ code. Once merged, we can bump folly to a newer version, which requires GCC 4.9.

Test Plan:

Everything build and run as usual.

Release Notes:

[ANDROID] [ENHANCEMENT] [NDK] - bump NDK_TOOLCHAIN_VERSION to 4.9

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 28, 2018
@react-native-bot react-native-bot added ✅Test Plan Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Jun 28, 2018
@dulmandakh
Copy link
Contributor Author

Please review @hramos @mdvacca

@hramos
Copy link
Contributor

hramos commented Jun 28, 2018

Also cc @fkgozali

@dulmandakh
Copy link
Contributor Author

@fkgozali please review and merge

@dulmandakh
Copy link
Contributor Author

Or maybe #19893, which does the same but also bumps NDK version. I tried every NDK version, and r14b was the latest version to compile with minimal code changes.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dulmandakh
Copy link
Contributor Author

@hramos is there any issue regarding merging this PR? I was able to compile RN with latest NDK, and would like to create a PR once this merged.

@hramos
Copy link
Contributor

hramos commented Jul 23, 2018

@dulmandakh No, no issues. We try to avoid landing diffs late on Friday afternoons. I'll get this going today.

@react-native-bot
Copy link
Collaborator

This pull request was closed by @dulmandakh in ccdd450.

Once this commit is added to a release, you will see the corresponding version tag below the description at ccdd450. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 23, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 23, 2018
@dulmandakh dulmandakh deleted the bump-ndk-toolchain-49 branch August 22, 2018 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants