Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue13077 #13104

Closed
wants to merge 2 commits into from
Closed

Issue13077 #13104

wants to merge 2 commits into from

Conversation

yairk
Copy link

@yairk yairk commented Mar 23, 2017

Motivation (required)

Fixes #13077: on Windows, when using autocrlf=true, then react-native link will fail to recognize that Android libraries have already been linked and will link them again.

Android's isInstalled.js now trims the pattern it's looking for so that it's newline-neutral. Note that react-native link will still unconditionally use a \n when patching the file, but git will automatically adjust this according to autocrlf upon a push + pull.

Test Plan (required)

Had some problems due to git newline manipulation to add separate build.gradle samples that will consistently have \n or \r\n on all platforms. :-/

Yair Manor (Kuszpet) added 2 commits March 23, 2017 09:03
…afe. Fixing issue 13077. Note that patches will still be applied only with a \\n, but git on Windows will correct this after a push/pull depending on autocrlf.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Mar 23, 2017
@hramos
Copy link
Contributor

hramos commented Apr 27, 2017

Can you expand your test plan? It's not clear how you tested this change at the moment.

@yairk
Copy link
Author

yairk commented Apr 27, 2017

I tested this by using it locally on my environment. See my note in the original pull request regarding testing challenges I had. I think the best way to test this might be with dynamically generated files?

@facebook-github-bot
Copy link
Contributor

@yairk I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@stale
Copy link

stale bot commented Oct 13, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 13, 2017
@stale stale bot closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants