Minor wording changes in PlatformColor.md #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found this section specially hard to read, so I'm proposing some minor tweaks that I think will make it easier to understand. I also added a mention to the fallback values which the function can receive, taking from the original PR which introduced the changes (facebook/react-native#27908) I don't know what the exact policy is on this, but since this was introduced in RN 0.63.0, perhaps this could also be clarified on the docs, as using it from an older version will throw a `_reactNative.PlatformColor is not a function` error.
|
Deploy preview for react-native ready! Built with commit c3fc0be https://deploy-preview-2053--react-native.netlify.app Changes to Thank you for your contributions. |
rachelnabors
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this section specially hard to read, so I'm proposing some minor tweaks that I think will make it easier to understand.
I also added a mention to the fallback values which the function can receive, taking from the original PR which introduced the changes (facebook/react-native#27908)
I don't know what the exact policy is on this, but since this was introduced in RN 0.63.0, perhaps this could also be clarified on the docs, as using it from an older version will throw a
_reactNative.PlatformColor is not a functionerror.