Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify pronunciation #438

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Clarify pronunciation #438

wants to merge 3 commits into from

Conversation

wreed4
Copy link

@wreed4 wreed4 commented Nov 22, 2023

According to other sources online, such as this post from facebook engineering and this medium article, the pronunciation is "mick router", like McDonalds. I personally love this pronunciation but others I work with disagree, citing the pronunciation on this page "mc router" as reading "emm see router". This PR clarifies that the more awesome pronunciation prevails.

@facebook-github-bot
Copy link
Contributor

Hi @wreed4!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@wreed4 wreed4 marked this pull request as ready for review November 22, 2023 14:35
Copy link

@sevrinrobstad sevrinrobstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I've always said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants