Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical] Feature: ctrl + (home key || end key) move to start/end #6646

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[lexical] Feature: ctrl + (home key || end key) move to start/end #6646

wants to merge 5 commits into from

Conversation

potatowagon
Copy link
Contributor

Description

Describe the changes in this pull request

Closes #

Test plan

Before

Insert relevant screenshots/recordings/automated-tests

After

Insert relevant screenshots/recordings/automated-tests

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 6:15am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 6:15am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2024
@potatowagon potatowagon marked this pull request as draft September 19, 2024 07:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 29.85 KB (0%)
lexical - esm 29.66 KB (0%)
@lexical/rich-text - cjs 38.3 KB (0%)
@lexical/rich-text - esm 31.55 KB (0%)
@lexical/plain-text - cjs 36.9 KB (0%)
@lexical/plain-text - esm 28.86 KB (0%)
@lexical/react - cjs 40.04 KB (0%)
@lexical/react - esm 32.91 KB (0%)

@ivailop7
Copy link
Collaborator

I'm a little confused, what bug is this solving? I've never had a problem with Home/End keys working correctly.

@potatowagon
Copy link
Contributor Author

potatowagon commented Sep 19, 2024 •
edited
Loading

I'm a little confused, what bug is this solving? I've never had a problem with Home/End keys working correctly.

we've got a request internally for ctrl + home to move the cursor to the start of the doc. i didnt know it was a thing but i guess no harm trying to support ctrl + home

@potatowagon potatowagon changed the title [lexical] home key and end key move to start/end [lexical] Feature: ctrl + (home key || end key) move to start/end Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@potatowagon @ivailop7 @facebook-github-bot