fix: delete horizontal node in table cell node

[keiseiTi]

Description

fix #6459

This commit solves the problem of continuing to execute subsequent logic when the first node in the ElementNode is decoratorNode

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2024 10:57am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2024 10:57am

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	29.77 KB (0%)
lexical - esm	29.6 KB (0%)
@lexical/rich-text - cjs	38.24 KB (0%)
@lexical/rich-text - esm	31.46 KB (0%)
@lexical/plain-text - cjs	36.82 KB (0%)
@lexical/plain-text - esm	28.86 KB (0%)
@lexical/react - cjs	40.01 KB (0%)
@lexical/react - esm	32.93 KB (0%)

[etrepum]

It would be great to have a test that demonstrates that this does fix it

[etrepum]

I'd probably re-order this to short-circuit with fewer function calls, e.g.

Suggested change

	if ($isElementNode(anchorNode)) {
	const childNode = anchorNode.getChildAtIndex(0);
	if ($isDecoratorNode(childNode) && anchor.offset === 0) {
	return;
	}
	}
	if (anchor.offset === 0 && $isElementNode(anchorNode) && $isDecoratorNode(anchorNode.getFirstChild())) {
	return;
	}

[etrepum]

I think the best solution is probably $isRootOrShadowRoot(anchorNode)? It would be nice to add a test and maybe a comment around here to describe what we're trying to do here

[zurfyx]

Thank you, can you expand on the problem? I believe there's an issue with selection and shadow root, backspace should never see beyond a shadow root. However, the horizontal line appears to be deletable as intended.

[etrepum]

The problem is that the decorator logic doesn't check for a shadow root. When you delete the paragraph before the HR, put the selection there (offset 0 of the TableCellNode), delete again it ends up deleting the TableCellNode when the expected behavior would be a no-op