You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you put together a repro that shows what goes wrong with this approach? It fixed all of the positioning issues that we could find, this revert is an OSS regression
Maybe a complete rewrite of the floating elements - context menu and typeahead/mentions/hashtags suggestions is worth it, maybe using something like https://floating-ui.com/ that would handle all of the render details correctly. All of those popovers are playground-only, so it should be OK relying on a 3rd party package for the rendering of these two. Just food for thought.
Yeah, Floating UI is what I used in the past for doing this sort of thing and it worked well. I don't have a strong opinion on whether we should have a dependency handle floating UI or have an in-tree implementation without known issues but we should certainly not have an in-tree implementation that we know is incorrect for the cases that we demonstrate.
Can you put together a repro that shows what goes wrong with this approach? It fixed all of the positioning issues that we could find, this revert is an OSS regression
reintroducing the changes back in #6566 but with gating so we can investigate internally and fix intern
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facebook-github-bot
added
the
CLA Signed
zurfyx
requested review from
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
Breaks internally, might need to revise the approach or our internal code...
…hen scroll (#6510)"
This reverts commit fd7a93d.
Description
Describe the changes in this pull request
Closes #
Test plan
Before
Insert relevant screenshots/recordings/automated-tests
After
Insert relevant screenshots/recordings/automated-tests