Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-website] Feature: Traditional Chinese Localization #6557

Open
wants to merge 67 commits into
base: main
Choose a base branch
from

Conversation

Edit-Mr
Copy link

@Edit-Mr Edit-Mr commented Aug 26, 2024

Description

Add Traditional Chinese Localization for docs

Here's an demo I deployed: https://lexical-lexical-website-git-demo-editmrs-projects.vercel.app/zh-Hant/

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ❌ Failed (Inspect) Aug 29, 2024 3:50pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:50pm

@facebook-github-bot
Copy link
Contributor

Hi @Edit-Mr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

github-actions bot commented Aug 26, 2024

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.22 KB (0%)
@lexical/rich-text - cjs 37.87 KB (0%)
@lexical/rich-text - esm 31.08 KB (0%)
@lexical/plain-text - cjs 36.45 KB (0%)
@lexical/plain-text - esm 28.44 KB (0%)
@lexical/react - cjs 39.64 KB (0%)
@lexical/react - esm 32.52 KB (0%)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2024
@ivailop7
Copy link
Collaborator

Hi there, the deployment still fails. Also, I'm unsure how the maintenance is going to be done of this documentation going forward and keep it in sync with the english language one.

@etrepum
Copy link
Collaborator

etrepum commented Sep 8, 2024

I agree with @ivailop7, this would be very difficult for the existing team to maintain. Maybe it would be better to maintain this externally, and when Lexical is more stable (>1.0 for sure) and has a larger team then official translations could be reconsidered, possibly following the translations.react.dev model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants