[lexical-react] remove editor__DEPRECATED that has been deprecated for two years #6494
Conversation
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
| @@ -23,7 +23,6 @@ export type InitialEditorStateType = | |||
| | ((editor: LexicalEditor) => void); | |||
|
|
|||
| export type InitialConfigType = $ReadOnly<{ | |||
| editor__DEPRECATED?: LexicalEditor | null, | |||
There was a problem hiding this comment.
editor__DEPRECATED is used some places on www,
https://www.internalfb.com/code/search?q=repo%3Awww%20editor__DEPRECATED
im not sure how backwards compatible this would be
@zurfyx should we try cleaning up editor__DEPRECATED in www first before syncing this over?
There was a problem hiding this comment.
@potatowagon Good point, we need to fix these occurrences first. I'll connect with you offline but unfortunately we should put this PR on hold for now
There was a problem hiding this comment.
I've converted to draft since we don't have a label for "on hold" or "don't merge"
|
I just recalled Chriss @montlebalm was mentioning use case with reusing editor instance via this prop: #4986 Wonder if it's used by other folks too and (although it was marked as deprecated forever) it worth having explicit exception when it's passed |
@fantactuka FWIW we're also using the same workaround described in the issue internally and that's not going away anytime soon |
|
@fantactuka I can't think of a good reason to render a |
Description
The
editor__DEPRECATEDprop has been deprecated for two years (#1407), this PR removes it.Test plan
There were no tests for this feature, and its absence does not need new tests.