Update base for Docker, remove python2 #1247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvillard
reviewed
Apr 1, 2020
jvillard
reviewed
Apr 1, 2020
|
Looks good, thanks! |
|
There seems to be a bug with Debian/Ubuntu Python:
|
There was a problem hiding this comment.
@jvillard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
skcho
reviewed
Apr 1, 2020
Co-Authored-By: skcho <cho.sungkeun@gmail.com>
|
@XVilka has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@jvillard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jvillard
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last missing piece for Python 2 removal also updated Docker base for the latest Debian Stable - Buster. Also selected 4.08.1 for the Java build as suggested i #1154 (comment)