Flipper doesn't build with Xcode 12.5 RC #2215

matiaskorhonen · 2021-04-21T08:55:14Z

🐛 Bug Report

Flipper in a React Native project fails to build with the following error:

~/MyProject/ios/Pods/Headers/Private/Flipper-Folly/folly/synchronization/DistributedMutex-inl.h:1051:5: 'atomic_notify_one<unsigned long>' is unavailable

Build log

[... TRUNCATED ...][]

In file included from ~/MyProject/ios/Pods/Flipper-Folly/folly/synchronization/DistributedMutex.cpp:17:
In file included from ~/MyProject/ios/Pods/Headers/Private/Flipper-Folly/folly/synchronization/DistributedMutex.h:344:
~/MyProject/ios/Pods/Headers/Private/Flipper-Folly/folly/synchronization/DistributedMutex-inl.h:1051:5: error: 'atomic_notify_one<unsigned long>' is unavailable
    atomic_notify_one(state);
    ^
~/MyProject/ios/Pods/Headers/Private/Flipper-Folly/folly/synchronization/DistributedMutex-inl.h:1573:5: note: in instantiation of function template specialization 'folly::detail::distributed_mutex::wakeTimedWaiters<std::__1::atomic<unsigned long>>' requested here
    wakeTimedWaiters(&state_, proxy.timedWaiters_);
    ^
In file included from ~/MyProject/ios/Pods/Flipper-Folly/folly/synchronization/DistributedMutex.cpp:17:
In file included from ~/MyProject/ios/Pods/Headers/Private/Flipper-Folly/folly/synchronization/DistributedMutex.h:19:
In file included from ~/MyProject/ios/Pods/Headers/Private/Flipper-Folly/folly/Optional.h:58:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk/usr/include/c++/v1/functional:504:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk/usr/include/c++/v1/memory:681:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk/usr/include/c++/v1/atomic:2140:6: note: 'atomic_notify_one<unsigned long>' has been explicitly marked unavailable here
void atomic_notify_one(atomic<_Tp>* __o) _NOEXCEPT
     ^
1 error generated.

[... TRUNCATED ...]

Build failed    21.4.2021, 11.51    34.5 seconds

Cleaning the Xcode build folder didn't help, nor does updating Flipper and Flipper-Folly to the latest versions.

To Reproduce

Install Xcode 12.5 RC from Apple
Open a React Native project with Flipper enabled
Try to build that project
The build fails

Environment

Xcode 12.5 RC
React Native 0.63.4
Pods:
- Flipper (0.85.0)
- Flipper-DoubleConversion (1.1.7)
- Flipper-Folly (2.5.1)
- Flipper-Glog (0.3.6)
- Flipper-PeerTalk (0.0.4)
- Flipper-RSocket (1.3.1)
- FlipperKit (0.85.0)

The text was updated successfully, but these errors were encountered:

avery-pierce · 2021-04-21T20:54:34Z

I'm getting the same error in our React Native app. Here's some related issues I was able to dig up:

facebook/folly#1527

facebook/react-native#31179

Looks like the underlying issue was resolved (here: facebook/folly@8477e25), but it hasn't been published to cocoapods yet.

OceanFlooor · 2021-04-25T03:26:17Z

Same as you. I feel no hope right now.
after tried every each solution, issue is still fucking there.

baveku · 2021-04-27T06:52:06Z

xCode 12.5 has released yesterday, this error still here. I hope we will be resolve the error for the next version

jonathanroze · 2021-04-27T07:24:44Z

Same issue by updating Xcode and my devices. Try many solutions but no one work.

baveku · 2021-04-27T07:27:40Z

Same issue by updating Xcode and my devices. Try many solutions but no one work.

I read facebook/folly@8477e25, the issue has resolved but flipper does not update yet

naicky-whiterain · 2021-04-27T08:18:02Z

same issue but why even I still disabled flipper on ios and I'm still getting a build error?

j2teamlbh · 2021-04-27T08:29:40Z

Now, i just need update this file and it run normally. Hope it will be resolve in the next version.
This file in:
{project-name}/ios/Pods/Flipper-Folly/folly/synchronization/DistributedMutex-inl.h

facebook/folly@8477e25#diff-65ad309ca9c636ba81eb7953fce06e6963c51296a60dc25eb4a5b1463482c6da

AlexHooperDev · 2021-04-27T13:48:15Z

same issue but why even I still disabled flipper on ios and I'm still getting a build error?

Me too - I get the following:

CompileC /Users/alex.hooper/Library/Developer/Xcode/DerivedData/Espresso-brgntaoyjolqyfdzcsunjlqtzzum/Build/Intermediates.noindex/Espresso.build/Debug-iphoneos/Espresso.build/Objects-normal/arm64/AppDelegate.o /Users/alex.hooper/Documents/figloo-bank-mobile/ios/Espresso/AppDelegate.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler

naicky-whiterain · 2021-04-27T14:02:16Z

Anyways, I was able to fix this by downgrading to XCode Version 12.4. It seems the issue for me happens when I updated my Xcode to the latest 12.5 version. until there's a patch to fix this, i will continue using 12.4 version

chrisid · 2021-04-27T14:07:16Z

This disables Flipper, but it's a quick workaround if you (like me) need the project working again.

Podfile, comment Flipper:

#   use_flipper!()
#   post_install do |installer|
#     react_native_post_install(installer)
#   end

cd ios and delete the 'Pods folder' folder and 'Podfile.lock'
pod install

naicky-whiterain · 2021-04-27T14:17:51Z

This disables Flipper, but it's a quick workaround if you (like me) need the project working again.

Podfile, comment Flipper:
#   use_flipper!()
#   post_install do |installer|
#     react_native_post_install(installer)
#   end
cd ios and delete the 'Pods folder' folder and 'Podfile.lock'

pod install

However this ain't working, tried numerous times there's still a build error. :(

Summary: `std::atomic_wait()` and `std::atomic_notify_one()` are marked as unavailable. Not really sure what that means, but it seems to be breaking some open source builds #1527. Explicitly qualify the calls into those functions to try and fix the build break. Since we cannot conditionally import either of the above (because they are marked as unavailable), we can't rely on the standard implementations. To prevent ADL from kicking in when the standard-library defines these, we fully qualify these and use `tag_invoke` for the customization points used in tests. Reviewed By: davidtgoldblatt Differential Revision: D26742072 fbshipit-source-id: 9f44bbfd37530f5ecffa3e03d673cfb1df953299

AlexHooperDev · 2021-04-27T14:30:40Z

Managed to use the temporary code fix above posted by j2teamlbh, what made it finally work was ensuring that in the podfile you specify that you're using use_flipper!({ 'Flipper-Folly' => '2.3.0' })

blueberry6401 · 2021-04-28T03:37:44Z

Sucks.

olie-chan · 2021-04-28T09:22:07Z

Managed to use the temporary code fix above posted by j2teamlbh, what made it finally work was ensuring that in the podfile you specify that you're using use_flipper!({ 'Flipper-Folly' => '2.3.0' })

@AlexHooperDev you wouldn't happen to know where I would put that change in my Podfile would you? I'm using using react native 62

platform :ios, '10.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

target 'foobarbazapp' do
  # Pods for foobarbazapp
  pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
  pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
  pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
  pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
  pod 'React', :path => '../node_modules/react-native/'
  pod 'React-Core', :path => '../node_modules/react-native/'
  pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
  pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
  pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
  pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
  pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
  pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
  pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
  pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
  pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
  pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
  pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'

  pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
  pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
  pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
  pod 'ReactCommon/callinvoker', :path => "../node_modules/react-native/ReactCommon"
  pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
  pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'



  pod 'Firebase/Messaging', '~> 6.13.0'
  pod 'Firebase/Core', '~> 6.13.0'
  pod 'Firebase/DynamicLinks', '~> 6.13.0'


  rn_maps_path = '../node_modules/react-native-maps'
  pod 'react-native-google-maps', :path => rn_maps_path
  pod 'GoogleMaps'
  pod 'Google-Maps-iOS-Utils'

  pod 'react-native-geolocation', path: '../node_modules/@react-native-community/geolocation'

  pod 'TrustKit', '~> 1.5.3'
  pod 'RNAzureNotificationHub', :podspec => '../node_modules/react-native-azurenotificationhub/RNAzureNotificationHub.podspec'


  target 'foobarbazappTests' do
    inherit! :search_paths
    # Pods for testing
  end

  use_native_modules!
end

target 'foobarbazapp-tvOS' do
  # Pods for foobarbazapp-tvOS

  target 'foobarbazapp-tvOSTests' do
    inherit! :search_paths
    # Pods for testing
  end

end

AlexHooperDev · 2021-04-28T09:26:25Z

Managed to use the temporary code fix above posted by j2teamlbh, what made it finally work was ensuring that in the podfile you specify that you're using use_flipper!({ 'Flipper-Folly' => '2.3.0' })

@AlexHooperDev you wouldn't happen to know where I would put that change in my Podfile would you? I'm using using react native 62

platform :ios, '10.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

target 'foobarbazapp' do
  # Pods for foobarbazapp
  pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
  pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
  pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
  pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
  pod 'React', :path => '../node_modules/react-native/'
  pod 'React-Core', :path => '../node_modules/react-native/'
  pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
  pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
  pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
  pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
  pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
  pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
  pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
  pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
  pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
  pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
  pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'

  pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
  pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
  pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
  pod 'ReactCommon/callinvoker', :path => "../node_modules/react-native/ReactCommon"
  pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
  pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'



  pod 'Firebase/Messaging', '~> 6.13.0'
  pod 'Firebase/Core', '~> 6.13.0'
  pod 'Firebase/DynamicLinks', '~> 6.13.0'


  rn_maps_path = '../node_modules/react-native-maps'
  pod 'react-native-google-maps', :path => rn_maps_path
  pod 'GoogleMaps'
  pod 'Google-Maps-iOS-Utils'

  pod 'react-native-geolocation', path: '../node_modules/@react-native-community/geolocation'

  pod 'TrustKit', '~> 1.5.3'
  pod 'RNAzureNotificationHub', :podspec => '../node_modules/react-native-azurenotificationhub/RNAzureNotificationHub.podspec'


  target 'foobarbazappTests' do
    inherit! :search_paths
    # Pods for testing
  end

  use_native_modules!
end

target 'foobarbazapp-tvOS' do
  # Pods for foobarbazapp-tvOS

  target 'foobarbazapp-tvOSTests' do
    inherit! :search_paths
    # Pods for testing
  end

end

It's up to you but I would put it below use_native_modules! end then run pod install

priteshrnandgaonkar · 2021-04-28T10:00:06Z

I will take a look at this by today or tomorrow and will release a new Flipper-Folly version.

priteshrnandgaonkar · 2021-04-28T14:48:56Z

The newer version of Folly depends on new dependency called fmt. So we will have to add a cocoapod dependency for that as well. Right now I am stuck at an issue from fmt where the xcode is not able to find the definition of the compile function.

The changes related to flipper-folly pod and fmt pod can be found here.

When I run pod spec lint Flipper-Folly.podspec --use-libraries --allow-warnings --verbose --skip-import-validation --sources=https://github.com/CocoaPods/Specs It gives me the following error

    - ERROR | [iOS] xcodebuild:  Headers/Public/Flipper-Fmt/fmt/compile.h:904:29: error: no matching function for call to 'compile'

Any idea how can I solve this ?

priteshrnandgaonkar · 2021-04-28T17:09:33Z

I have solved the above error. Now fixing the other errors.

priteshrnandgaonkar · 2021-04-28T18:29:02Z

I have released a new Flipper-Folly version of 2.5.2. Give it a try. It points to the latest Folly release. The latest folly release also depends on a fmt library, the pod of which is also published as Flipper-Fmt.

Do try using Flipper-Folly version of 2.5.2 and let me know if it fixes the issue.

shamilovtim · 2021-04-28T18:36:26Z

[!] CocoaPods could not find compatible versions for pod "Flipper-Folly":
  In Podfile:
    Flipper-Folly (= 2.5.2)

None of your spec sources contain a spec satisfying the dependency: `Flipper-Folly (= 2.5.2)`.

You have either:
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

How are we to update Flipper-Folly?

priteshrnandgaonkar · 2021-04-28T18:40:37Z

Run pod repo update and then run pod install.

esinanturan · 2021-04-28T18:42:32Z

tried but still same error

my-name-is-nheo · 2021-04-28T18:44:48Z

@priteshrnandgaonkar deleted the podfile-lock and folder, those commands still led me to install 2.5.1

shamilovtim · 2021-04-28T18:46:41Z

I seem to get 2.5.1 no matter what, and I don't have a hash in the lockfile locking it to that version

my-name-is-nheo · 2021-04-28T21:02:39Z

@avery-pierce Yea @nicholasc 's advise on downgrading back to 2.5.1 and following #2215 (comment) did not work for me. I'm trying to get my app on testflight. (product->analyze) hopefully this is the case for some of you

shamilovtim · 2021-04-28T21:04:00Z

For now I've disabled Flipper on iOS and our project builds now

lParraMediaCurrent · 2021-04-28T21:57:03Z

For now I've disabled Flipper on iOS and our project builds now

What specifically you did for it?

priteshrnandgaonkar · 2021-04-28T22:12:51Z

As a hotfix I have patched 2.5.1 with the above mentioned patch in Flipper-Folly 2.5.3

I will follow up with RN folks regarding consolidating Flipper-Folly and RCT-Folly into one and have a consistent workflow of maintaining it.

But for now Flipper-Folly 2.5.3 should unblock.

teajohnson90 · 2021-04-28T22:21:49Z

This disables Flipper, but it's a quick workaround if you (like me) need the project working again.

Podfile, comment Flipper:
#   use_flipper!()
#   post_install do |installer|
#     react_native_post_install(installer)
#   end
cd ios and delete the 'Pods folder' folder and 'Podfile.lock'

pod install
However this ain't working, tried numerous times there's still a build error. :(

This worked for me, thanks!

shamilovtim · 2021-04-28T22:22:14Z

For now I've disabled Flipper on iOS and our project builds now

What specifically you did for it?

In Podfile comment the following:

//1
#  pod 'react-native-flipper', :path => '../node_modules/react-native-flipper/react-native-flipper.podspec', :configuration => 'Debug'

//2
#  use_flipper!({'Flipper' => '0.87.0', 'Flipper-Folly' => '2.5.2'})

//3
#    flipper_post_install(pi)

Then npx pod-install afterwards

shamilovtim · 2021-04-28T22:58:38Z

It would be nice if you could get with them and get them to commit to removing Flipper from CRNA and expo init. This package is below 1.0, is woefully slow and plagued by instability and performance variance between different versions and frequently has breaking changes. It doesn't belong in starter templates and it shouldn't be a requirement for getting started with React Native. The amount of downtime, CI slowness, failed and slowed builds it has caused could probably be valued in the hundreds of thousands of $$$, all because someone made the decision to make the RN community guinea pigs for this tool. Reactotron is infinitely better despite being created by a third party, not updated for 2 years and swizzling APIs that Facebook didn't open to it. I have a 2020 MBP and Flipper performs terribly on it. What audience is this tool really intended for if it can't perform on a new MBP, breaks frequently, and slows down people's builds? Now lets say it finally performs like its contemporaries, tools like VSCode or whatever else. Then I'd understand, and I'd probably even use it. But why is it in production now in the state that it is?

smooney211993 · 2021-04-28T23:07:11Z

This worked for me. On react native 0.63.4
use_flipper!({ 'Flipper-Folly' => '2.5.3', 'Flipper' => '0.87.0', 'Flipper-RSocket' => '1.3.1' })

smooney211993 · 2021-04-28T23:13:29Z

As a hotfix I have patched 2.5.1 with the above mentioned patch in Flipper-Folly 2.5.3

I will follow up with RN folks regarding consolidating Flipper-Folly and RCT-Folly into one and have a consistent workflow of maintaining it.

But for now Flipper-Folly 2.5.3 should unblock.

THANKS

kkelley-leftbrain · 2021-04-29T01:10:11Z

This worked for me. On react native 0.63.4
use_flipper!({ 'Flipper-Folly' => '2.5.3', 'Flipper' => '0.87.0', 'Flipper-RSocket' => '1.3.1' })

Trying the above got me past the errors others described, but I'm now running into Unknown type name 'BN_ULONG' which I've (potentially) ran down to a versioning issue on the dependency of OpenSSL-Universal

from the Podfile.lock:

  - Flipper-Folly (2.5.3):
    - boost-for-react-native
    - Flipper-DoubleConversion
    - Flipper-Glog
    - libevent (~> 2.1.12)
    - OpenSSL-Universal (= 1.1.180)

A somewhat recent issue on the subject is here

I'm newish to react-native when it comes to custom managing the versions like this, does anyone have any advice on how I can resolve?

my-name-is-nheo · 2021-04-29T03:29:32Z

@priteshrnandgaonkar will check it out later. thank you for staying on top of this.

debianw · 2021-04-29T06:02:25Z

After updating to Flipper-Folly 2.5.3 I'm getting this build error: event2/event-config.h file not found

willgriffiths · 2021-04-29T06:55:06Z

@kkelley-leftbrain I got past OpenSSL issues by adding the version of OpenSSL-Universal in the Podfile:

target 'MyApp' do
  ...
  pod 'OpenSSL-Universal', '~>1.1.180' 
  ...  
  use_flipper!({ 'Flipper-Folly' => '2.5.3', 'Flipper' => '0.87.0', 'Flipper-RSocket' => '1.3.1' })
  post_install do |installer|
    flipper_post_install(installer)
  end
end

In my case it was previously pinned to an older version.

ShivamJoker · 2021-04-29T08:24:01Z

Still getting the same error after updating and reinstalling pods ?
any workaround you guys did ? my flipper config is already commented in podfile

❌  /Users/shivam/Documents/ReactNative/SQL-Playground/ios/Pods/Headers/Private/RCT-Folly/folly/synchronization/DistributedMutex-inl.h:1051:5: 'atomic_notify_one<unsigned long>' is unavailable

    atomic_notify_one(state);
    ^

umang-simform · 2021-04-29T08:46:55Z

Still getting the same error after updating and reinstalling pods ?
any workaround you guys did ? my flipper config is already commented in podfile
❌  /Users/shivam/Documents/ReactNative/SQL-Playground/ios/Pods/Headers/Private/RCT-Folly/folly/synchronization/DistributedMutex-inl.h:1051:5: 'atomic_notify_one<unsigned long>' is unavailable

    atomic_notify_one(state);
    ^

Yes because they have updated Flipper-folly not RCT-folly,
You will need to add these lines to your podfile

use_flipper!({ 'Flipper-Folly' => '2.5.3', 'Flipper' => '0.87.0', 'Flipper-RSocket' => '1.3.1' })


  # Define find-and-replace function
  def find_and_replace(dir, findstr, replacestr)
    Dir[dir].each do |name|
        text = File.read(name)
        replace = text.gsub(findstr,replacestr)
        replaced = text.index(replacestr)
        if replaced == nil && text != replace
            puts "Fix: " + name
            File.open(name, "w") { |file| file.puts replace }
            STDOUT.flush
        end
    end
    Dir[dir + '*/'].each(&method(:find_and_replace))
  end

  post_install do |installer|
    react_native_post_install(installer)
    installer.pods_project.targets.each do |target|
      target.build_configurations.each do |config|
        config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64'
        end
    end
    
#     Fix for Flipper-Folly on iOS 14.5
#    These are no longer required as Flipper-folly is updated
#   find_and_replace("Pods/Flipper-Folly/folly/synchronization/DistributedMutex-inl.h",
#                    "atomic_notify_one(state)", "folly::atomic_notify_one(state)")

#   find_and_replace("Pods/Flipper-Folly/folly/synchronization/DistributedMutex-inl.h",
#   "atomic_wait_until(&state, previous | data, deadline)", "folly::atomic_wait_until(&state, previous | data, deadline)")

  find_and_replace("Pods/RCT-Folly/folly/synchronization/DistributedMutex-inl.h",
                   "atomic_notify_one(state)", "folly::atomic_notify_one(state)")

  find_and_replace("Pods/RCT-Folly/folly/synchronization/DistributedMutex-inl.h",
  "atomic_wait_until(&state, previous | data, deadline)", "folly::atomic_wait_until(&state, previous | data, deadline)")

    
  end

IronTony · 2021-04-29T10:02:41Z

This worked for me. On react native 0.63.4
use_flipper!({ 'Flipper-Folly' => '2.5.3', 'Flipper' => '0.87.0', 'Flipper-RSocket' => '1.3.1' })

This works perfectly! Just do pod install --repo-update and everything will be fine! Thank you!

ShivamJoker · 2021-04-29T10:06:13Z

@umang-simform the solution you gave is giving me open ssl error while installing/updating pods.

[!] Error installing OpenSSL-Universal
[!] /usr/bin/git clone https://github.com/krzyzanowskim/OpenSSL.git /var/folders/p8/8d4bmlwn6858cz1x0szgzv940000gn/T/d20210429-20276-18dmikn --template= --single-branch --depth 1 --branch 1.1.180

Cloning into '/var/folders/p8/8d4bmlwn6858cz1x0szgzv940000gn/T/d20210429-20276-18dmikn'...
error: 7467 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: index-pack failed

AlixH · 2021-04-29T10:17:33Z

This worked for me. On react native 0.63.4
use_flipper!({ 'Flipper-Folly' => '2.5.3', 'Flipper' => '0.87.0', 'Flipper-RSocket' => '1.3.1' })

After doing this, I am getting the following error:

Undefined symbols for architecture x86_64:
  "Swift._ArrayBuffer._copyContents(initializing: Swift.UnsafeMutableBufferPointer<A>) -> (Swift.IndexingIterator<Swift._ArrayBuffer<A>>, Swift.Int)", referenced from:
      generic specialization <serialized, Swift._ArrayBuffer<Swift.Int8>> of Swift._copyCollectionToContiguousArray<A where A: Swift.Collection>(A) -> Swift.ContiguousArray<A.Element> in libCharts.a(ChartUtils.o)
ld: symbol(s) not found for architecture x86_64

Any ideas ?

priteshrnandgaonkar · 2021-04-29T10:27:36Z

Those getting RCT-Folly errors, please follow facebook/react-native#31179

I am closing this as the issue from Flipper side is resolved.

tomphilbin · 2021-04-29T10:55:06Z

Yes because they have updated Flipper-folly not RCT-folly,
You will need to add these lines to your podfile

use_flipper!({ 'Flipper-Folly' => '2.5.3', 'Flipper' => '0.87.0', 'Flipper-RSocket' => '1.3.1' })


  # Define find-and-replace function
  def find_and_replace(dir, findstr, replacestr)
    Dir[dir].each do |name|
        text = File.read(name)
        replace = text.gsub(findstr,replacestr)
        replaced = text.index(replacestr)
        if replaced == nil && text != replace
            puts "Fix: " + name
            File.open(name, "w") { |file| file.puts replace }
            STDOUT.flush
        end
    end
    Dir[dir + '*/'].each(&method(:find_and_replace))
  end

  post_install do |installer|
    react_native_post_install(installer)
    installer.pods_project.targets.each do |target|
      target.build_configurations.each do |config|
        config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64'
        end
    end
    
#     Fix for Flipper-Folly on iOS 14.5
#    These are no longer required as Flipper-folly is updated
#   find_and_replace("Pods/Flipper-Folly/folly/synchronization/DistributedMutex-inl.h",
#                    "atomic_notify_one(state)", "folly::atomic_notify_one(state)")

#   find_and_replace("Pods/Flipper-Folly/folly/synchronization/DistributedMutex-inl.h",
#   "atomic_wait_until(&state, previous | data, deadline)", "folly::atomic_wait_until(&state, previous | data, deadline)")

  find_and_replace("Pods/RCT-Folly/folly/synchronization/DistributedMutex-inl.h",
                   "atomic_notify_one(state)", "folly::atomic_notify_one(state)")

  find_and_replace("Pods/RCT-Folly/folly/synchronization/DistributedMutex-inl.h",
  "atomic_wait_until(&state, previous | data, deadline)", "folly::atomic_wait_until(&state, previous | data, deadline)")

    
  end

Thanks @umang-simform this worked great for our team, we just had to add the following line before calling find_and_replace:

system('chmod +rw Pods/RCT-Folly/folly/synchronization/DistributedMutex-inl.h')

jonathanroze · 2021-04-29T13:08:15Z

Hey guys they push a new version.

You just need to edit your code to that

  use_flipper!({ 'Flipper' => '0.87.0' })
  post_install do |installer|
    flipper_post_install(installer)
  end

And run npx pod-install

my-name-is-nheo · 2021-04-29T15:20:18Z

@AlixH did you find a solution to this? been getting the same error.

guillewu · 2021-04-29T15:22:33Z

@my-name-is-nheo @AlixH I'm having a very similar error. I ended up giving up and just downgraded back to xcode 12.4 😞

JuanpaG94 · 2021-04-29T15:28:23Z

Guys please stop asking, read the comments, they already fixed it and they give the solution

AlixH · 2021-04-29T15:36:55Z

@AlixH did you find a solution to this? been getting the same error.

facebook/react-native#31179 (comment)

azuxx · 2021-04-29T16:15:06Z

Guys please stop asking, read the comments, they already fixed it and they give the solution

sorry, but where we can find this final solution? Would be great if someone can pin it for us please.

I updated to Big Sur, so I have now XCode Version 12.5 (12E262), I also updated from 0.63.4 to 0.64.0 but XCode build still fails. Would be great if we can build our app again and ship them to the clients in the very next few days.

Thanks

jonathanroze · 2021-04-29T16:17:06Z

Hey guys they push a new version.

You just need to edit your code to that
  use_flipper!({ 'Flipper' => '0.87.0' })
  post_install do |installer|
    flipper_post_install(installer)
  end
And run npx pod-install

@azuxx

mweststrate · 2021-04-29T16:33:11Z

Locking now since the original issue is solved. Please see the comment directly above and this one. For RTC-Folly issues please follow up in facebook/react-native#31179. For any new issues open a fresh issue including Podfile & lock file

lucasjohnston mentioned this issue Apr 27, 2021

Folly DistributedMutex using unavailable methods. facebook/folly#1527

Open

iaroslav-ternovyi mentioned this issue Apr 27, 2021

0.61.5 → 0.62.0 RCTBridgeModule Error facebook/react-native#28405

Closed

robbiemccorkell mentioned this issue Apr 27, 2021

iOS won't build on fresh project with latest MacOS 11.3 and Xcode 12.5 facebook/react-native#31441

Closed

aparedes mentioned this issue Apr 28, 2021

react-native run-ios build failure on XCode 12.5 beta react-native-community/cli#1365

Closed

robbiemccorkell mentioned this issue Apr 28, 2021

New RN project will not build on Xcode 12.5 Beta 3 facebook/react-native#31179

Closed

priteshrnandgaonkar closed this as completed Apr 29, 2021

facebook locked as resolved and limited conversation to collaborators Apr 29, 2021

Flipper doesn't build with Xcode 12.5 RC #2215

Flipper doesn't build with Xcode 12.5 RC #2215

Comments

matiaskorhonen commented Apr 21, 2021 • edited Loading

🐛 Bug Report

To Reproduce

Environment

avery-pierce commented Apr 21, 2021

OceanFlooor commented Apr 25, 2021

baveku commented Apr 27, 2021

jonathanroze commented Apr 27, 2021

baveku commented Apr 27, 2021 • edited Loading

naicky-whiterain commented Apr 27, 2021

j2teamlbh commented Apr 27, 2021 • edited Loading

AlexHooperDev commented Apr 27, 2021

naicky-whiterain commented Apr 27, 2021

chrisid commented Apr 27, 2021 • edited Loading

naicky-whiterain commented Apr 27, 2021

AlexHooperDev commented Apr 27, 2021

blueberry6401 commented Apr 28, 2021

olie-chan commented Apr 28, 2021 • edited Loading

AlexHooperDev commented Apr 28, 2021

priteshrnandgaonkar commented Apr 28, 2021

priteshrnandgaonkar commented Apr 28, 2021

priteshrnandgaonkar commented Apr 28, 2021

priteshrnandgaonkar commented Apr 28, 2021

shamilovtim commented Apr 28, 2021

priteshrnandgaonkar commented Apr 28, 2021

esinanturan commented Apr 28, 2021

my-name-is-nheo commented Apr 28, 2021

shamilovtim commented Apr 28, 2021

my-name-is-nheo commented Apr 28, 2021 • edited Loading

shamilovtim commented Apr 28, 2021

lParraMediaCurrent commented Apr 28, 2021

priteshrnandgaonkar commented Apr 28, 2021

teajohnson90 commented Apr 28, 2021

shamilovtim commented Apr 28, 2021

shamilovtim commented Apr 28, 2021

smooney211993 commented Apr 28, 2021

smooney211993 commented Apr 28, 2021

kkelley-leftbrain commented Apr 29, 2021 • edited Loading

my-name-is-nheo commented Apr 29, 2021

debianw commented Apr 29, 2021 • edited Loading

willgriffiths commented Apr 29, 2021 • edited Loading

ShivamJoker commented Apr 29, 2021

umang-simform commented Apr 29, 2021

IronTony commented Apr 29, 2021

ShivamJoker commented Apr 29, 2021

AlixH commented Apr 29, 2021

priteshrnandgaonkar commented Apr 29, 2021

tomphilbin commented Apr 29, 2021

jonathanroze commented Apr 29, 2021

my-name-is-nheo commented Apr 29, 2021

guillewu commented Apr 29, 2021

JuanpaG94 commented Apr 29, 2021

AlixH commented Apr 29, 2021

azuxx commented Apr 29, 2021

jonathanroze commented Apr 29, 2021

mweststrate commented Apr 29, 2021

matiaskorhonen commented Apr 21, 2021 •

edited

Loading

baveku commented Apr 27, 2021 •

edited

Loading

j2teamlbh commented Apr 27, 2021 •

edited

Loading

chrisid commented Apr 27, 2021 •

edited

Loading

olie-chan commented Apr 28, 2021 •

edited

Loading

my-name-is-nheo commented Apr 28, 2021 •

edited

Loading

kkelley-leftbrain commented Apr 29, 2021 •

edited

Loading

debianw commented Apr 29, 2021 •

edited

Loading

willgriffiths commented Apr 29, 2021 •

edited

Loading