fix(babel-plugin-fbt): detect fbt JS callsites from FbtCollector [master] #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@kayhadrin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
kayhadrin
changed the title
…ebook#263) Summary: Running string extraction from JS files containing only `<fbs>` or `fbs()` callsites doesn't work. This PR should fix it. Pull Request resolved: facebook#263 Test Plan: `yarn clean-test` Differential Revision: D30744411 Pulled By: kayhadrin fbshipit-source-id: cc6a1b948184f08f3ae702e1c1b6f53f286f2578
kayhadrin
force-pushed
the
fix/fbs-detection-in-fbt-collect
branch
from
761a1d5
to
8b24d3f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30744411 |
|
@kayhadrin merged this pull request in ec2a5ee. |
bestsoftwaretopappreviews09
added a commit
to bestsoftwaretopappreviews09/fbt
that referenced
this pull request
Sep 10, 2024
Summary: Running string extraction from JS files containing only `<fbs>` or `fbs()` callsites doesn't work. This PR should fix it. Pull Request resolved: facebook/fbt#263 Test Plan: `yarn clean-test` Reviewed By: pkqinys Differential Revision: D30744411 Pulled By: kayhadrin fbshipit-source-id: cb563d7cbfad047176db127a7395e187e060ec09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running string extraction from JS files containing only
<fbs>orfbs()callsites doesn't work.This PR should fix it.
Test plan
yarn clean-test