Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blog): improve doc global data hook error message + add doc warning to blogOnly mode #9839

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

OzakIOne
Copy link
Collaborator

@OzakIOne OzakIOne commented Feb 9, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Error log when disabling doc to have docusaurus in blog only mode and using doc feature in docusaurus.config.js isn't clear to the user

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 9, 2024
Copy link

netlify bot commented Feb 9, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 4414a5f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65c65ab9d3098b00087d4e9a
😎 Deploy Preview https://deploy-preview-9839--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 9, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 74 🟢 98 🟢 100 🟢 100 🟠 88 Report
/docs/installation 🟠 67 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 59 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 69 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 77 🟢 100 🟢 100 🟢 90 🟠 88 Report

website/docs/blog.mdx Outdated Show resolved Hide resolved
@slorber slorber changed the title docs(blog-only): add warning and improve error log docs(blog): add warning and improve error log Feb 9, 2024
@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Feb 9, 2024
@slorber slorber changed the title docs(blog): add warning and improve error log refactor(blog): add warning and improve error log Feb 9, 2024
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Feb 9, 2024
@slorber slorber changed the title refactor(blog): add warning and improve error log refactor(blog): improve doc global data hook error message + add doc warning to blogOnly mode Feb 9, 2024
@slorber slorber merged commit a296d72 into facebook:main Feb 9, 2024
33 checks passed
@slorber slorber deleted the ozaki/errorlog branch February 9, 2024 18:34
@slorber slorber mentioned this pull request Feb 13, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy. to backport This PR is planned to be backported to a stable version of Docusaurus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants