Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not fail the build if a localized site has a broken link #9339

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 22, 2023

Motivation

i18n / Crowdin is often a reason why the production website build fails.

And Markdown broken links is a good subset of those i18n errors.
Example: https://app.netlify.com/sites/docusaurus-2/deploys/650db064f9a39f1221ed9487

Failing the prod build due to community translations is annoying, so let's only warn for localized broken links.

Those broken links in i18n sites are less important and can be fixed in batch.

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Sep 22, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 22, 2023
@netlify
Copy link

netlify bot commented Sep 22, 2023

[V2]

Name Link
🔨 Latest commit d8dff86
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/650db6543f85c30008f0df39
😎 Deploy Preview https://deploy-preview-9339--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 87 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 87 🟢 98 🟢 92 🟢 100 🟠 89 Report

@slorber slorber merged commit 46407ec into main Sep 22, 2023
11 of 12 checks passed
@slorber slorber deleted the slorber/onBrokenLinks-i18n branch September 22, 2023 15:50
@github-actions
Copy link

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 117 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 838 kB
website/build/index.html 41.4 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants