Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require Node 16.14 #7501

Merged
merged 3 commits into from
May 26, 2022
Merged

chore: require Node 16.14 #7501

merged 3 commits into from
May 26, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Required for #7463.

@slorber Error.prototype.cause is added in v16.10, so if we want to use that, we have to go to 16.10.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. label May 26, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 26, 2022
@Josh-Cena
Copy link
Collaborator Author

error jest@28.1.0: The engine "node" is incompatible with this module. Expected version "^12.13.0 || ^14.15.0 || ^16.10.0 || >=17.0.0". Got "16.0.0"

Sigh I think we'll go to 16.10.0, then. Thanks Jest!

@Josh-Cena Josh-Cena changed the title chore: require Node 16 chore: require Node 16.10 May 26, 2022
@netlify
Copy link

netlify bot commented May 26, 2022

[V2]

Name Link
🔨 Latest commit cd52f4f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628f2de2fe53d900083e9694
😎 Deploy Preview https://deploy-preview-7501--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 26, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 66 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 84 🟢 99 🟢 100 🟢 100 🟢 90 Report

@netlify
Copy link

netlify bot commented May 26, 2022

[V2]

Name Link
🔨 Latest commit 5f4beaf
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628f4610d6e63c0008af85fe
😎 Deploy Preview https://deploy-preview-7501--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 26, 2022

Size Change: 0 B

Total Size: 796 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 598 kB
website/build/index.html 38.9 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented May 26, 2022

The error cause language feature was added in 16.10, but apparently we need 16.14 if we want proper nested stacktrace logging (separate node PR/feature)

CleanShot 2022-05-26 at 11 15 21@2x

The minor version diff may not change much for users so what about moving directly to >= 16.14 + >= 18.0 ?

This way we can safely finally use error-cause

@Josh-Cena Josh-Cena changed the title chore: require Node 16.10 chore: require Node 16.14 May 26, 2022
@Josh-Cena
Copy link
Collaborator Author

OK! This is a huge leap forward.

@slorber
Copy link
Collaborator

slorber commented May 26, 2022

👍

@slorber slorber merged commit 47a2cca into main May 26, 2022
@slorber slorber deleted the jc/node-16 branch May 26, 2022 09:44
@ghost ghost mentioned this pull request Mar 3, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: breaking change Existing sites may not build successfully in the new version. Description contains more details.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants