Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape period #10223

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: escape period #10223

merged 1 commit into from
Jun 17, 2024

Conversation

d4nyll
Copy link
Contributor

@d4nyll d4nyll commented Jun 17, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I believe the intended purpose of looksLikeAsset is to check for request URLs that ends with a file extension (e.g. .mp4). But without escaping the period, it will match every URL that ends with a sequence of 4 alphanumeric characters.

Test Plan

N/A

Test links

Deploy preview: https://deploy-preview-10223--docusaurus-2.netlify.app/

Related issues/PRs

The related code was added in #10142

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 17, 2024
Copy link

netlify bot commented Jun 17, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f857207
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66704c8e01bebe000864bda2
😎 Deploy Preview https://deploy-preview-10223--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 53 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 51 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 68 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 61 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 71 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

@d4nyll d4nyll marked this pull request as ready for review June 17, 2024 15:03
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, thanks

@Josh-Cena Josh-Cena merged commit 71ba685 into facebook:main Jun 17, 2024
33 checks passed
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 17, 2024
@d4nyll d4nyll deleted the patch-1 branch June 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants