Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fork-ts-checker-webpack-plugin out of alpha #6739

Merged
merged 1 commit into from
Apr 6, 2019
Merged

Update fork-ts-checker-webpack-plugin out of alpha #6739

merged 1 commit into from
Apr 6, 2019

Conversation

pelotom
Copy link
Contributor

@pelotom pelotom commented Apr 1, 2019

No description provided.

@ianschmitz ianschmitz added this to the 3.0 milestone Apr 2, 2019
@ianschmitz
Copy link
Contributor

Thanks for the PR. This looks to have caused our behavior suite to fail vs master.

@ianschmitz ianschmitz modified the milestones: 3.0, 3.x Apr 2, 2019
@pelotom
Copy link
Contributor Author

pelotom commented Apr 2, 2019

@ianschmitz

Thanks for the PR. This looks to have caused our behavior suite to fail vs master.

How can you tell? master is broken too, it looks like with the same errors.

@ianschmitz
Copy link
Contributor

Ah yes i see that now. Sorry about that. Our CI builds are having a bad time.

@ianschmitz ianschmitz closed this Apr 6, 2019
@ianschmitz ianschmitz reopened this Apr 6, 2019
@ianschmitz ianschmitz modified the milestones: 3.x, 3.0 Apr 6, 2019
@ianschmitz ianschmitz merged commit c03d6b1 into facebook:master Apr 6, 2019
@pelotom pelotom deleted the patch-4 branch April 6, 2019 21:37
@lock lock bot locked and limited conversation to collaborators Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@gaearon gaearon Awaiting requested review from gaearon

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
CLA Signed tag: underlying tools
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pelotom @ianschmitz @facebook-github-bot