InlineChunkHtmlPlugin works with empty publicPath (#6735)

* InlineChunkHtmlPlugin works with empty publicPath * Update as requested
facebook · Apr 16, 2019 · fdbb550 · fdbb550
1 parent bffc296
commit fdbb550
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/react-dev-utils/InlineChunkHtmlPlugin.js b/packages/react-dev-utils/InlineChunkHtmlPlugin.js
@@ -17,7 +17,7 @@ class InlineChunkHtmlPlugin {
     if (tag.tagName !== 'script' || !(tag.attributes && tag.attributes.src)) {
       return tag;
     }
-    const scriptName = tag.attributes.src.replace(publicPath, '');
+    const scriptName = publicPath ? tag.attributes.src.replace(publicPath, '') : tag.attributes.src;
     if (!this.tests.some(test => scriptName.match(test))) {
       return tag;
     }
@@ -29,8 +29,8 @@ class InlineChunkHtmlPlugin {
   }
 
   apply(compiler) {
-    let publicPath = compiler.options.output.publicPath;
-    if (!publicPath.endsWith('/')) {
+    let publicPath = compiler.options.output.publicPath || '';
+    if (publicPath && !publicPath.endsWith('/')) {
       publicPath += '/';
     }