Skip to content

Commit

Permalink
Port cra.sh development task to javascript (#2309)
Browse files Browse the repository at this point in the history
* Port cra.sh development task to javascript

* Port cra.sh development task to javascript

Use absolute path when generating .tgz path
  • Loading branch information
ianschmitz authored and gaearon committed Jan 9, 2018
1 parent 11f09a1 commit b20b96a
Show file tree
Hide file tree
Showing 3 changed files with 110 additions and 85 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"scripts": {
"build": "node packages/react-scripts/scripts/build.js",
"changelog": "lerna-changelog",
"create-react-app": "tasks/cra.sh",
"create-react-app": "node tasks/cra.js",
"e2e": "tasks/e2e-simple.sh",
"e2e:docker": "tasks/local-test.sh",
"postinstall": "node bootstrap.js && cd packages/react-error-overlay/ && npm run build:prod",
Expand Down
109 changes: 109 additions & 0 deletions tasks/cra.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
#!/usr/bin/env node
/**
* Copyright (c) 2015-present, Facebook, Inc.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

'use strict';

const fs = require('fs');
const path = require('path');
const cp = require('child_process');

const cleanup = () => {
console.log('Cleaning up.');
// Uncomment when snapshot testing is enabled by default:
// rm ./template/src/__snapshots__/App.test.js.snap
};

const handleExit = () => {
cleanup();
console.log('Exiting without error.');
process.exit();
};

const handleError = e => {
console.error('ERROR! An error was encountered while executing\n', e);
cleanup();
console.log('Exiting with error.');
process.exit(1);
};

process.on('SIGINT', handleExit);
process.on('uncaughtException', handleError);

// ******************************************************************************
// Pack react- scripts so we can verify they work.
// ******************************************************************************

const rootDir = path.join(__dirname, '..');
const reactScriptsDir = path.join(rootDir, 'packages', 'react-scripts');
const packageJsonPath = path.join(reactScriptsDir, 'package.json');
const packageJsonOrigPath = path.join(reactScriptsDir, 'package.json.orig');

// Install all our packages
const lernaPath = path.join(rootDir, 'node_modules', '.bin', 'lerna');
cp.execSync(`${lernaPath} bootstrap`, {
cwd: rootDir,
stdio: 'inherit',
});

// Save package.json because we're going to touch it
fs.writeFileSync(packageJsonOrigPath, fs.readFileSync(packageJsonPath));

// Replace own dependencies (those in the`packages` dir) with the local paths
// of those packages
const replaceOwnDepsPath = path.join(__dirname, 'replace-own-deps.js');
cp.execSync(`node ${replaceOwnDepsPath}`, { stdio: 'inherit' });

// Finally, pack react-scripts
// Don't redirect stdio as we want to capture the output that will be returned
// from execSync(). In this case it will be the .tgz filename.
const scriptsFileName = cp
.execSync(`npm pack`, { cwd: reactScriptsDir })
.toString()
.trim();
const scriptsPath = path.join(
rootDir,
'packages',
'react-scripts',
scriptsFileName
);

// Restore package.json
fs.unlinkSync(packageJsonPath);
fs.writeFileSync(packageJsonPath, fs.readFileSync(packageJsonOrigPath));
fs.unlinkSync(packageJsonOrigPath);

// ******************************************************************************
// Now that we have packed them, call the global CLI.
// ******************************************************************************

// If Yarn is installed, clean its cache because it may have cached react-scripts
try {
cp.execSync('yarn cache clean');
} catch (e) {
// We can safely ignore this as the user doesn't have yarn installed
}

const args = process.argv.slice(2);

// Now run the CRA command
const craScriptPath = path.join(
rootDir,
'packages',
'create-react-app',
'index.js'
);
cp.execSync(
`node ${craScriptPath} --scripts-version="${scriptsPath}" ${args.join(' ')}`,
{
cwd: rootDir,
stdio: 'inherit',
}
);

// Cleanup
handleExit();
84 changes: 0 additions & 84 deletions tasks/cra.sh

This file was deleted.

0 comments on commit b20b96a

Please sign in to comment.