Skip to content

Commit

Permalink
Added ability to specify multiple directories in node_path.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jimmy Miller authored and gaearon committed Sep 2, 2016
1 parent 6e94bd8 commit 82066ac
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 9 deletions.
22 changes: 19 additions & 3 deletions config/paths.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@

var path = require('path');

// We support resolving modules according to NODE_PATH.
// This lets you use absolute paths in imports inside large monorepos:
// https://github.com/facebookincubator/create-react-app/issues/253.
// It works just like NODE_PATH in Node:
// https://nodejs.org/api/modules.html#modules_loading_from_the_global_folders
// We will export `nodePaths` as an array of absolute paths.
// It will then be used by Webpack (and potentially other tools).
var nodePaths = (process.env.NODE_PATH || '')
.split(process.platform === 'win32' ? ';' : ':')
.filter(Boolean)
.map(p => path.resolve(p));

function resolveApp(relativePath) {
return path.resolve(relativePath);
}
Expand All @@ -22,13 +34,15 @@ module.exports = {
appPackageJson: resolveApp('package.json'),
appSrc: resolveApp('src'),
appNodeModules: resolveApp('node_modules'),
ownNodeModules: resolveApp('node_modules')
ownNodeModules: resolveApp('node_modules'),
nodePaths: nodePaths
};

// @remove-on-eject-begin
function resolveOwn(relativePath) {
return path.resolve(__dirname, relativePath);
}

// config before eject: we're in ./node_modules/react-scripts/config/
module.exports = {
appBuild: resolveApp('build'),
Expand All @@ -37,7 +51,8 @@ module.exports = {
appSrc: resolveApp('src'),
appNodeModules: resolveApp('node_modules'),
// this is empty with npm3 but node resolution searches higher anyway:
ownNodeModules: resolveOwn('../node_modules')
ownNodeModules: resolveOwn('../node_modules'),
nodePaths: nodePaths
};
// @remove-on-eject-end

Expand All @@ -48,6 +63,7 @@ module.exports = {
appPackageJson: resolveOwn('../package.json'),
appSrc: resolveOwn('../template/src'),
appNodeModules: resolveOwn('../node_modules'),
ownNodeModules: resolveOwn('../node_modules')
ownNodeModules: resolveOwn('../node_modules'),
nodePaths: nodePaths
};
// @remove-on-publish-end
8 changes: 5 additions & 3 deletions config/webpack.config.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,11 @@ module.exports = {
publicPath: '/'
},
resolve: {
// This allows you to set a root for where webpack should look for modules.
// This enables you to use absolute imports from the root.
root: path.resolve(process.env.NODE_PATH || ''),
// This allows you to set a root for where Webpack should look for modules.
// It must be an absolute path or an array of absolute paths.
// This lets you use absolute paths in imports inside large monorepos:
// https://github.com/facebookincubator/create-react-app/issues/253.
root: paths.nodePaths,
// These are the reasonable defaults supported by the Node ecosystem.
extensions: ['.js', '.json', ''],
alias: {
Expand Down
8 changes: 5 additions & 3 deletions config/webpack.config.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,11 @@ module.exports = {
publicPath: publicPath
},
resolve: {
// This allows you to set a root for where webpack should look for modules.
// This enables you to use absolute imports from the root.
root: path.resolve(process.env.NODE_PATH || ''),
// This allows you to set a root for where Webpack should look for modules.
// It must be an absolute path or an array of absolute paths.
// This lets you use absolute paths in imports inside large monorepos:
// https://github.com/facebookincubator/create-react-app/issues/253.
root: paths.nodePaths,
// These are the reasonable defaults supported by the Node ecosystem.
extensions: ['.js', '.json', ''],
alias: {
Expand Down

0 comments on commit 82066ac

Please sign in to comment.