Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buck2_validation: tweak and slightly improve error message #769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

buck2_validation: tweak and slightly improve error message #769

wants to merge 1 commit into from

Commits on Sep 20, 2024

  1. buck2_validation: tweak and slightly improve error message 

    Previously, when using `ValidationInfo()` with a failure, it ends up turning out
an awkward message that turns

    { "status": "failure", "message": "you failed the test!" }

into

    "you failed the test!".

After this patch, it comes out as:

    you failed the test!

Which seems much more reasonable and easy to parse. It also gives the validation
message more control over the punctuation.

Signed-off-by: Austin Seipp <aseipp@pobox.com>
    @thoughtpolice
    thoughtpolice committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8b24471 View commit details
    Browse the repository at this point in the history