Vis Svelte | Fix component lifecycle logic #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
@rokotyan I spent some time investigating this and it seemed like the best thing to do was to change the way we handle component lifecycles in our svelte wrapper.
Before:
undefined
to remove it from the container's config. This created a unique issue for axis because we need to know which config key (i.e. xAxis or yAxis) to makeundefined
. A workaround could have been to make an additional method calledremoveAxis
but that seemed convoluted to me. I wanted to rethink our current approach and further separate the component logic from the container's.Changes:
onDestroy
that will be called later.destroy()
method is called on the wrapped components themselves now. I'm not sure how important it is but I realized we didn't do that before like we do in our react wrapper.