Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Half Donut Vertical Centering #444

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Half Donut Vertical Centering #444

wants to merge 5 commits into from

Conversation

curran
Copy link

@curran curran commented Sep 5, 2024 •
edited
Loading

Work In Progress Towards #441

@curran
Copy link
Author

curran commented Sep 5, 2024

Current status:

image

@curran curran mentioned this pull request Sep 5, 2024
Open
2 tasks
@curran
Copy link
Author

curran commented Sep 11, 2024

Current status: This PR makes the half donut centered vertically.

image

I think this is ready for review and testing. Thanks!

@curran curran marked this pull request as ready for review September 11, 2024 16:00
@curran curran changed the title WIP Half Donut Half Donut Vertical Centering Sep 11, 2024
@curran
Copy link
Author

curran commented Sep 11, 2024

Direction forward:

  • Modify the examples to showcase the responsive behavior of all pie examples when resizing the SVG both vertically and horizontally
  • Compute the bounding box that surrounds the donut
  • Use the bounding box for the scaling logic to fill the available space in the SVG

@curran curran marked this pull request as draft September 11, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@curran