Website | Gallery: Fix expandable sankey data model #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#180
Background:
The error was occurring because
data.nodes
anddata.links
weren't in sync. Previously, only thenode
objects were updated when setting a node'sexpanded
property, whilelinks
remained unchanged, resulting in links with unrecognized source and target values when Sankey wasn't fully expanded. (I suspect changes from Datamodel | Graph: Fix link data logic (8b4416d) are what ultimately broke it)Changes :
This PR:
data.ts
file to maintain clarity in the component code