Component | LeafletMap: POC of having an object of CSS variable names #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokotyan
force-pushed
the
feature/css-variables-map-camel-case
branch
from
8f2ab2d
to
cf93c64
Compare
reb-dev
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time I was concerned about the names of CSS variables in Unovis: we reference them in the TS code and every time the name of a certain variable changes, we need to manually change it everywhere else
This PR is a proof of concept of having the names of component's CSS variables stored in an object, that can be used in the code and can be accessed externally as a static class property.