Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodbye lodash #100

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Goodbye lodash #100

merged 5 commits into from
Feb 22, 2023

Conversation

rokotyan
Copy link
Contributor

This PR replaces lodash with our own functions and uses throttle from the throttle-debounce package, saving the users about 90KB in the final app bundle.

Before

Screen Shot 2023-01-13 at 1 11 25 PM

After

Screen Shot 2023-01-13 at 1 08 46 PM

@rokotyan rokotyan added the enhancement New feature or request label Jan 13, 2023
@rokotyan rokotyan added this to the Release v1.1.0 milestone Jan 13, 2023
@rokotyan rokotyan requested a review from reb-dev January 13, 2023 21:21
@rokotyan rokotyan self-assigned this Jan 13, 2023
@rokotyan rokotyan marked this pull request as draft January 13, 2023 21:21
reb-dev
reb-dev reviewed Jan 19, 2023
View reviewed changes
packages/ts/package.json Outdated
@@ -61,6 +61,7 @@
"@types/lodash-es": "^4.17.6",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove this too?

@reb-dev
Copy link
Collaborator

reb-dev commented Jan 19, 2023

We also need to remove the lodash/sample import and all of the references to it in packages/website/docs/networks-and-flows/Graph.mdx. Currently when you try to run the website this page crashes.

@rokotyan
Copy link
Contributor Author

@reb-dev Thanks for pointing our the issues! I've just fixed along with a few other thing.

@rokotyan rokotyan marked this pull request as ready for review February 1, 2023 23:24
reb-dev
reb-dev previously approved these changes Feb 2, 2023
View reviewed changes
@rokotyan rokotyan merged commit dc6556a into main Feb 22, 2023
@rokotyan rokotyan linked an issue Mar 1, 2023 that may be closed by this pull request
Dependencies: Get rid of lodash #23
Closed
@rokotyan rokotyan mentioned this pull request Apr 19, 2023
Merged
@rokotyan rokotyan deleted the feature/goodbye-lodash branch May 22, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reb-dev reb-dev reb-dev approved these changes

Assignees

@rokotyan rokotyan

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v1.1.0
Development

Successfully merging this pull request may close these issues.

Dependencies: Get rid of lodash
2 participants
@rokotyan @reb-dev