Skip to content

Commit

Permalink
ci: test with Python 3.12 (#230)
Browse files Browse the repository at this point in the history
With our recent version upgrades, tests also succeed with Python 3.12.
By adding testing with Python 3.12, we can ensure that ghstack works
with all current Python versions.
  • Loading branch information
felix-seifert committed Dec 21, 2023
1 parent e45bc13 commit 6893bb2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
runs-on: ${{ matrix.os }}
steps:
Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ Conveniently submit stacks of diffs to GitHub as separate pull requests.
pip3 install ghstack
```

Python 3.8.1 and greater only. For Python 3.12, dependencies might still need some fixing.
ghstack is tested with
[several different Python versions](https://github.com/ezyang/ghstack/blob/master/.github/workflows/test.yml#L13).
It requires at least Python 3.8.1.

## How to setup

Expand Down

0 comments on commit 6893bb2

Please sign in to comment.