Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix errors in ci github action for node 8 and 9 #104

Merged
merged 1 commit into from
May 14, 2024
Merged

ci: fix errors in ci github action for node 8 and 9 #104

merged 1 commit into from
May 14, 2024

Conversation

inigomarquinez
Copy link
Member

This PR fixes nyc version to 14.1.1 when running tests in node 8 or node 9. nyc 15.x requires a yargs package version that requires node >=10.

I've also added the latest versions of node (18, 19, 20, 21 and 22) to the matrix.

Related to jshttp/http-errors#108

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon UlisesGascon merged commit ca4c97e into expressjs:master May 14, 2024
26 checks passed
@UlisesGascon
Copy link
Member

The CI patch worked as expected, see for more details.

@6km 6km mentioned this pull request May 15, 2024
@inigomarquinez inigomarquinez deleted the ci/fix-tests-in-node-8-and-9 branch May 16, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants