Remove deprecated property "xde" from the manifest (#3366)

* Remove deprecated property "xde" from the manifest This property has been deprecated since 2018 and its use in the SDK was removed here: expo/expo@2807b09 * Update CHANGELOG
expo · Apr 8, 2021 · c63aaf4 · c63aaf4
1 parent d4a4427
commit c63aaf4
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,8 @@ This is the log of notable changes to Expo CLI and related packages.
 
 ### 🛠 Breaking changes
 
+- Remove deprecated property `xde` from the manifest ([#3366](https://github.com/expo/expo-cli/pull/3366))
+
 ### 🎉 New features
 
 ### 🧹 Chores
@@ -288,7 +290,7 @@ This is the log of notable changes to Expo CLI and related packages.
 
 ### 📦 Packages updated
 
-  - @expo/config-plugins@1.0.18
+- @expo/config-plugins@1.0.18
 - @expo/config@3.3.28
 - @expo/dev-server@0.1.54
 - @expo/dev-tools@0.13.82

diff --git a/packages/config/src/Config.types.ts b/packages/config/src/Config.types.ts
@@ -63,7 +63,6 @@ export type ExpoAppManifest = ExpoConfig & {
   sdkVersion: string;
   bundledAssets?: string[];
   isKernel?: boolean;
-  xde?: boolean;
   kernel?: { androidManifestPath?: string; iosManifestPath?: string };
   assetUrlOverride?: string;
   publishedTime?: string;

diff --git a/packages/webpack-config/src/webpack.config.ts b/packages/webpack-config/src/webpack.config.ts
@@ -321,7 +321,6 @@ export default async function (
   // TODO(Bacon): Move to expo/config - manifest code from XDL Project
   const publicConfig = {
     ...config,
-    xde: true,
     developer: {
       tool: 'expo-cli',
       projectRoot: env.projectRoot,

diff --git a/packages/xdl/src/start/ManifestHandler.ts b/packages/xdl/src/start/ManifestHandler.ts
@@ -200,7 +200,6 @@ export async function getManifestResponseAsync({
   const hostInfo = await createHostInfoAsync();
   const [projectSettings, bundleUrlPackagerOpts] = await getPackagerOptionsAsync(projectRoot);
   // Mutate the manifest
-  manifest.xde = true; // deprecated
   manifest.developer = {
     tool: Config.developerTool,
     projectRoot,