Node 12 (JITless) support #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaer
force-pushed
the
node-12-jitless
branch
2 times, most recently
from
90dccfd
to
2d6b398
Compare
|
This should be building on node 12 now. |
Closed
avaer
commented
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
shawwn
reviewed
Mar 22, 2019
Closed
|
Note that to use this feature, you probably want the Node 12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 now supports running in JITless mode and there is a PR to bring it into node.
With this feature, we can run Exokit on more platforms, including iOS, which disallow the executable writable memory policy that V8 uses by default.
The main task for us in exoland is to make sure we are compatible with Node 12. The V8 API changed a bit re:
v8::Handlehere, and some deprecated methods were removed. This PR makes the necessary changes to exokit and collects the needed external module updates.Notably we would need to do this work anyway when Node 12 comes around in April.
Continuation of #871; thanks to @shawwn for the research and bootstrapping that work.