Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Convert state.srcCharCode -> state.src #84

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Conversation

chrisjsewell
Copy link
Member

state.srcCharCode is deprecated in markdown-it-py v3, and so here we pre-emptively replace all incidences to state.src, i.e. using the string instead of the unicode integer.

`state.srcCharCode` is deprecated in markdown-it-py v3,
and so here we pre-emptively replace all incidences to `state.src`,
i.e. using the string instead of the unicode integer.
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch coverage: 97.05% and project coverage change: -0.11 ⚠️

Comparison is base (85f7ed3) 92.80% compared to head (b6e5c52) 92.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   92.80%   92.70%   -0.11%     
==========================================
  Files          31       31              
  Lines        1779     1781       +2     
==========================================
  Hits         1651     1651              
- Misses        128      130       +2     
Flag Coverage Δ
pytests 92.70% <97.05%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mdit_py_plugins/colon_fence.py 94.59% <86.66%> (-2.29%) ⬇️
mdit_py_plugins/attrs/index.py 92.10% <100.00%> (-0.07%) ⬇️
mdit_py_plugins/container/index.py 96.87% <100.00%> (-0.04%) ⬇️
mdit_py_plugins/deflist/index.py 94.28% <100.00%> (-0.09%) ⬇️
mdit_py_plugins/dollarmath/index.py 91.12% <100.00%> (ø)
mdit_py_plugins/field_list/__init__.py 95.90% <100.00%> (ø)
mdit_py_plugins/footnote/index.py 94.82% <100.00%> (-0.03%) ⬇️
mdit_py_plugins/front_matter/index.py 94.52% <100.00%> (-0.08%) ⬇️
mdit_py_plugins/myst_blocks/index.py 95.60% <100.00%> (ø)
mdit_py_plugins/myst_role/index.py 85.36% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrisjsewell chrisjsewell merged commit 6f2e2a7 into master Jun 3, 2023
@chrisjsewell chrisjsewell deleted the rm-srcCharCode branch June 3, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant