Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Fix type of MockIncludeDirective’s klass parameter #975

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

flying-sheep
Copy link
Contributor

Fixes #974

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks!

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (8a567c5) to head (75ffe7c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          24       24           
  Lines        3507     3507           
=======================================
  Hits         3167     3167           
  Misses        340      340           
Flag Coverage Δ
pytests 90.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell changed the title Fix type of MockIncludeDirective’s klass parameter 🔧 Fix type of MockIncludeDirective’s klass parameter Sep 13, 2024
@chrisjsewell chrisjsewell merged commit 6bcba98 into executablebooks:master Sep 13, 2024
20 checks passed
@flying-sheep flying-sheep deleted the patch-1 branch September 13, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MockIncludeDirective klass parameter has a wrong type hint
2 participants